Closed Bug 737867 Opened 8 years ago Closed 8 years ago

Apply ViewHolder pattern on AwesomeBar listviews

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
blocking-fennec1.0 --- +

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(3 files)

This should give us a 4-5fps increase when scrolling awesomebar views due to the reduced number of findViewById() calls in each adapter.
blocking-fennec1.0: --- → ?
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

I'd like to get feedback from Margaret as she did a lot of work on the bookmarks adapter.
Attachment #607968 - Flags: feedback?(margaret.leibovic)
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

This looks good to me. I was reading up on the ViewHolder pattern, and you seem to be following what I've seen.

Although I wrote this code, I'm wondering why we don't have an @Override tag on getItemViewType, since the things I've read talked about overriding getItemViewType if you're using multiple list item types.
Attachment #607968 - Flags: feedback?(margaret.leibovic) → feedback+
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

Looks OK to me too. I had to "read up" on the ViewHolder pattern too :)
Attachment #607968 - Flags: review?(mark.finkle) → review+
Attachment #607969 - Flags: review?(mark.finkle) → review+
Attachment #607970 - Flags: review?(mark.finkle) → review+
blocking-fennec1.0: ? → +
Depends on: 740094
Comment on attachment 607970 [details] [diff] [review]
(3/3) Share same LayoutInflater instance in AwesomeBarTabs

Mobile only. Release blocker.
Attachment #607970 - Flags: approval-mozilla-aurora?
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

Mobile only. Release blocker.
Attachment #607968 - Flags: approval-mozilla-aurora?
Comment on attachment 607969 [details] [diff] [review]
(2/3) Apply ViewHolder pattern on AwesomeBar's History tab

Mobile only. Release blocker.
Attachment #607969 - Flags: approval-mozilla-aurora?
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

[Triage Comment]
Mobile only & blocking Fennec 1.0. Approved for Aurora 13.
Attachment #607968 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #607969 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #607970 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.