Apply ViewHolder pattern on AwesomeBar listviews

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

Trunk
Firefox 14
All
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, blocking-fennec1.0 +)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
This should give us a 4-5fps increase when scrolling awesomebar views due to the reduced number of findViewById() calls in each adapter.
(Assignee)

Comment 1

5 years ago
Created attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs
Attachment #607968 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

5 years ago
Created attachment 607969 [details] [diff] [review]
(2/3) Apply ViewHolder pattern on AwesomeBar's History tab
Attachment #607969 - Flags: review?(mark.finkle)
(Assignee)

Comment 3

5 years ago
Created attachment 607970 [details] [diff] [review]
(3/3) Share same LayoutInflater instance in AwesomeBarTabs
Attachment #607970 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
blocking-fennec1.0: --- → ?
(Assignee)

Comment 4

5 years ago
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

I'd like to get feedback from Margaret as she did a lot of work on the bookmarks adapter.
Attachment #607968 - Flags: feedback?(margaret.leibovic)

Comment 5

5 years ago
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

This looks good to me. I was reading up on the ViewHolder pattern, and you seem to be following what I've seen.

Although I wrote this code, I'm wondering why we don't have an @Override tag on getItemViewType, since the things I've read talked about overriding getItemViewType if you're using multiple list item types.
Attachment #607968 - Flags: feedback?(margaret.leibovic) → feedback+
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

Looks OK to me too. I had to "read up" on the ViewHolder pattern too :)
Attachment #607968 - Flags: review?(mark.finkle) → review+
Attachment #607969 - Flags: review?(mark.finkle) → review+
Attachment #607970 - Flags: review?(mark.finkle) → review+
blocking-fennec1.0: ? → +
(Assignee)

Comment 7

5 years ago
Pushed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/9b69a0003faf
http://hg.mozilla.org/integration/mozilla-inbound/rev/1b3fc8a81634
http://hg.mozilla.org/integration/mozilla-inbound/rev/4cf5f398d6bf

Updated

5 years ago
Depends on: 740094

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9b69a0003faf
https://hg.mozilla.org/mozilla-central/rev/1b3fc8a81634
https://hg.mozilla.org/mozilla-central/rev/4cf5f398d6bf
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Comment 9

5 years ago
Comment on attachment 607970 [details] [diff] [review]
(3/3) Share same LayoutInflater instance in AwesomeBarTabs

Mobile only. Release blocker.
Attachment #607970 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 10

5 years ago
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

Mobile only. Release blocker.
Attachment #607968 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 11

5 years ago
Comment on attachment 607969 [details] [diff] [review]
(2/3) Apply ViewHolder pattern on AwesomeBar's History tab

Mobile only. Release blocker.
Attachment #607969 - Flags: approval-mozilla-aurora?
Comment on attachment 607968 [details] [diff] [review]
(1/3) Apply ViewHolder pattern in AwesomeBar's All/Bookmarks tabs

[Triage Comment]
Mobile only & blocking Fennec 1.0. Approved for Aurora 13.
Attachment #607968 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #607969 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #607970 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/398778e61a9d
https://hg.mozilla.org/releases/mozilla-aurora/rev/4c2e0ab2fa4f
https://hg.mozilla.org/releases/mozilla-aurora/rev/07b68ea1083f
status-firefox13: --- → fixed
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.