Bookmarks folder icons don't appear anymore

VERIFIED FIXED in Firefox 13

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

({regression})

Trunk
Firefox 14
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 610240 [details] [diff] [review]
patch

This is a regression caused by bug 737867. We shouldn't call updateFavicon for folder item types, since the favicon is just always the folder icon.

I tested this patch and it fixes the problem.
Attachment #610240 - Flags: review?(lucasr.at.mozilla)

Updated

5 years ago
Attachment #610240 - Flags: review?(lucasr.at.mozilla) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2c747fcacea
Target Milestone: --- → Firefox 14

Updated

5 years ago
Duplicate of this bug: 740299
https://hg.mozilla.org/mozilla-central/rev/b2c747fcacea
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 4

5 years ago
Verified/fixed on:
Nightly Fennec 14.0a1 (2012-04-01)
Device: Samsung Nexus S
OS: Android 2.3.6
Status: RESOLVED → VERIFIED
status-firefox14: --- → verified
(Assignee)

Comment 5

5 years ago
Comment on attachment 610240 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 737867
User impact if declined: bookmark folder icons don't appear
Testing completed (on m-c, etc.): Landed on m-c 3/29
Risk to taking this patch (and alternatives if risky): low risk, mobile only
String changes made by this patch: None
Attachment #610240 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 610240 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 13.
Attachment #610240 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/b88204f7e018
status-firefox13: --- → fixed
You need to log in before you can comment on or make changes to this bug.