Closed Bug 740094 Opened 8 years ago Closed 8 years ago

Bookmarks folder icons don't appear anymore

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached patch patchSplinter Review
This is a regression caused by bug 737867. We shouldn't call updateFavicon for folder item types, since the favicon is just always the folder icon.

I tested this patch and it fixes the problem.
Attachment #610240 - Flags: review?(lucasr.at.mozilla)
Attachment #610240 - Flags: review?(lucasr.at.mozilla) → review+
Duplicate of this bug: 740299
https://hg.mozilla.org/mozilla-central/rev/b2c747fcacea
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified/fixed on:
Nightly Fennec 14.0a1 (2012-04-01)
Device: Samsung Nexus S
OS: Android 2.3.6
Status: RESOLVED → VERIFIED
Comment on attachment 610240 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 737867
User impact if declined: bookmark folder icons don't appear
Testing completed (on m-c, etc.): Landed on m-c 3/29
Risk to taking this patch (and alternatives if risky): low risk, mobile only
String changes made by this patch: None
Attachment #610240 - Flags: approval-mozilla-aurora?
Comment on attachment 610240 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora 13.
Attachment #610240 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.