Closed Bug 740094 Opened 13 years ago Closed 13 years ago

Bookmarks folder icons don't appear anymore

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox13 fixed, firefox14 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 14
Tracking Flags:
Tracking Status
firefox13 --- fixed
firefox14 --- verified

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.26 KB, patch
lucasr
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review
This is a regression caused by bug 737867. We shouldn't call updateFavicon for folder item types, since the favicon is just always the folder icon. I tested this patch and it fixes the problem.
Attachment #610240 - Flags: review?(lucasr.at.mozilla)
Attachment #610240 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b2c747fcacea
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/b2c747fcacea
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified/fixed on: Nightly Fennec 14.0a1 (2012-04-01) Device: Samsung Nexus S OS: Android 2.3.6
Status: RESOLVED → VERIFIED
status-firefox14: --- → verified
Comment on attachment 610240 [details] [diff] [review] patch [Approval Request Comment] Regression caused by (bug #): bug 737867 User impact if declined: bookmark folder icons don't appear Testing completed (on m-c, etc.): Landed on m-c 3/29 Risk to taking this patch (and alternatives if risky): low risk, mobile only String changes made by this patch: None
Attachment #610240 - Flags: approval-mozilla-aurora?
Comment on attachment 610240 [details] [diff] [review] patch [Triage Comment] Mobile only - approved for Aurora 13.
Attachment #610240 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: