B2G Wifi: Consolidate ctypes-related worker code

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: philikon, Assigned: philikon)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

There's a little bit of code duplication between the Wifi code and the workers in dom/system/gonk. This is a first attempt at consolidating some of this. More can be done later.
Created attachment 608119 [details] [diff] [review]
v1

* Rename "network_worker.js" to "wifi_worker.js" to avoid confusion with the Network Manager's worker ("net_worker.js" in dom/system/gonk).
* Reuse the libnetutils ctypes wrapper from systemlibs.js
* Inline libcutils ctypes wrapper for now. systemlibs provides a Javascript-y interface to those functions, so eventually we should consolidate this, but we can leave for a later time. Same with consolidating libhardware_legacy.js and systemlibs.js. Small patches ftw, etc.
Attachment #608119 - Flags: review?(mrbkap)

Updated

5 years ago
Attachment #608119 - Flags: review?(mrbkap) → review+
Comment on attachment 608119 [details] [diff] [review]
v1

Thx for the review. I should've said that I was going away for a few days so that somebody else could've landed it. Bug 739115 obsoleted this patch now. I'll produce a new one.
Attachment #608119 - Attachment is obsolete: true
Blocks: 739452
Created attachment 610744 [details] [diff] [review]
v2

Ported the bug 739115 goodness to systemlibs.js, obsoleting libnetutils.js once more. Rest of the patch is the same which was already r+'ed, so I'm going to have cjones rubberstamp this one since he wrote the fix for bug 739115.
Attachment #610744 - Flags: review?(jones.chris.g)
Comment on attachment 610744 [details] [diff] [review]
v2

Nice JS garbage fix in stringToIp.
Attachment #610744 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a54e16971488
https://hg.mozilla.org/mozilla-central/rev/a54e16971488
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.