Closed Bug 738163 Opened 12 years ago Closed 12 years ago

resource://gre/modules/mailServices.js should be resource:///modules/mailServices.js.

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(seamonkey2.11 fixed)

RESOLVED FIXED
seamonkey2.11
Tracking Status
seamonkey2.11 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Mail Services was introduced in Bug 700899 - Port |Bug 193281 - Ability to import/save e-mail messages from .eml text files to folders (Message|Copy)|.
http://hg.mozilla.org/comm-central/annotate/dca487087cf1/suite/mailnews/mailWindowOverlay.js#l52
http://hg.mozilla.org/comm-central/rev/3ab8b701b57e#l3.12

See: Bug 736495 (Some scripts are importing modules with resource:///gre instead of resource:/// and vice-versa) for why resource://gre/modules/mailServices.js should be resource:///modules/mailServices.js.
Attachment #608268 - Flags: superreview?(mnyromyr)
Attachment #608268 - Flags: review?(mnyromyr)
Comment on attachment 608268 [details] [diff] [review]
Patch v1.0 one liner.

Review of attachment 608268 [details] [diff] [review]:
-----------------------------------------------------------------

Would you care to fix
/mailnews/imap/test/unit/test_saveTemplate.js
    * line 44 -- Components.utils.import("resource://gre/modules/mailServices.js");
too?

::: suite/mailnews/mailWindowOverlay.js
@@ +53,1 @@
>  Components.utils.import("resource:///modules/folderUtils.jsm");

Nit: sort it after folderUtils.jsm.
Attachment #608268 - Flags: feedback+
> Would you care to fix...
Please file a separate bug for /mailnews as they have different reviewers and review rules.
Attachment #608268 - Flags: superreview?(mnyromyr)
Attachment #608268 - Flags: superreview+
Attachment #608268 - Flags: review?(mnyromyr)
Attachment #608268 - Flags: review+
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/03468b543189
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.11
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> /mailnews/imap/test/unit/test_saveTemplate.js
>     * line 44 --
> Components.utils.import("resource://gre/modules/mailServices.js");

Bug 739782 Submitted
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: