Closed
Bug 738196
Opened 13 years ago
Closed 11 years ago
document.styleSheets should be iterable
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: dao, Assigned: Ms2ger)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-needed)
Attachments
(2 files, 2 obsolete files)
|
8.93 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
27.21 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
[x for (x of document.styleSheets)]
Error: document.styleSheets is not iterable
|
||
Comment 1•13 years ago
|
||
Is this just a matter of switching document.styleSheets to the new list bindings?
|
Assignee | |
Updated•13 years ago
|
Assignee: general → Ms2ger
Component: JavaScript Engine → DOM: Core & HTML
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
This caused leaks I didn't get around to figuring out.
Assignee: Ms2ger → nobody
Blocks: ParisBindings
|
||
Comment 5•11 years ago
|
||
Can we give this another shot? Maybe the world looks a little different now...
|
|
||
Comment 6•11 years ago
|
||
Ms2ger, mind updating the patches to trunk? The patch in bug 978646 might well have fixed that leak...
Flags: needinfo?(Ms2ger)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → Ms2ger
Flags: needinfo?(Ms2ger)
|
|
Assignee | |
Comment 7•11 years ago
|
||
It turned out the code changed enough that I was better off starting from scratch.
Attachment #724987 -
Attachment is obsolete: true
Attachment #724988 -
Attachment is obsolete: true
Attachment #8399143 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #8399144 -
Flags: review?(bzbarsky)
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 8399143 [details] [diff] [review]
Part a: introduce a common superclass for nsDOMStyleSheetList and ShadowRootStyleSheetList
Please do file a followup to change nsDocument to storing nsCSSStyleSheet* and/or eliminate nsIStyleSheet?
r=me
Attachment #8399143 -
Flags: review?(bzbarsky) → review+
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8399144 [details] [diff] [review]
Part b: move StyleSheetList to WebIDL
>+++ b/content/base/src/ShadowRoot.h
> class ShadowRootStyleSheetList : public StyleSheetList
>+ NS_DECL_ISUPPORTS
NS_DECL_ISUPPORTS_INHERITED, please!
>+++ b/content/base/src/nsDocument.h
> NS_DECL_ISUPPORTS
Likewise.
r=me with those fixed. Thank you!
Attachment #8399144 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 11•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/da45b16f1541
https://hg.mozilla.org/integration/mozilla-inbound/rev/02d0214c5e37
Flags: in-testsuite?
|
|
Assignee | |
Comment 12•11 years ago
|
||
|
||
Comment 13•11 years ago
|
||
Push(es) backed out for something therein causing failures of form:
https://tbpl.mozilla.org/php/getParsedLog.php?id=37568923&tree=Mozilla-Inbound
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=7db109e3a02b
|
|
||
Comment 14•11 years ago
|
||
Almost certainly not related to this bug, fwiw.
|
|
Assignee | |
Comment 15•11 years ago
|
||
|
||
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bb922d22d392
https://hg.mozilla.org/mozilla-central/rev/17af503e70cc
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
|
||
Updated•11 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•