Closed Bug 738196 Opened 9 years ago Closed 7 years ago
.style Sheets should be iterable
[x for (x of document.styleSheets)] Error: document.styleSheets is not iterable
Is this just a matter of switching document.styleSheets to the new list bindings?
Assignee: general → Ms2ger
This caused leaks I didn't get around to figuring out.
Assignee: Ms2ger → nobody
Can we give this another shot? Maybe the world looks a little different now...
Ms2ger, mind updating the patches to trunk? The patch in bug 978646 might well have fixed that leak...
Assignee: nobody → Ms2ger
It turned out the code changed enough that I was better off starting from scratch.
Comment on attachment 8399143 [details] [diff] [review] Part a: introduce a common superclass for nsDOMStyleSheetList and ShadowRootStyleSheetList Please do file a followup to change nsDocument to storing nsCSSStyleSheet* and/or eliminate nsIStyleSheet? r=me
Attachment #8399143 - Flags: review?(bzbarsky) → review+
Comment on attachment 8399144 [details] [diff] [review] Part b: move StyleSheetList to WebIDL >+++ b/content/base/src/ShadowRoot.h > class ShadowRootStyleSheetList : public StyleSheetList >+ NS_DECL_ISUPPORTS NS_DECL_ISUPPORTS_INHERITED, please! >+++ b/content/base/src/nsDocument.h > NS_DECL_ISUPPORTS Likewise. r=me with those fixed. Thank you!
Attachment #8399144 - Flags: review?(bzbarsky) → review+
Push(es) backed out for something therein causing failures of form: https://tbpl.mozilla.org/php/getParsedLog.php?id=37568923&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=7db109e3a02b
Almost certainly not related to this bug, fwiw.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in before you can comment on or make changes to this bug.