738304 - Many non Firefox Toolbar Buttons broken due to bug 735691

Status: RESOLVED INCOMPLETE

(Firefox :: Theme, defect)

Description

[Girish Sharma [:Optimizer]]

Some Toolbar buttons from extensions appear to be acting weirdly.
1. They don't have any hover state.
2. The drop down marker (which should appear on the right of text/image) appears behind the text (when the button has text only) aligned horizontally center with respect to the button.

Comment 1

[Dão Gottwald [:dao]]

Could you please attach a screenshot?

What extensions in particular are affected?

Comment 2

[Girish Sharma [:Optimizer]]

Attachment: Button Comparison

In particular : Proxy Selector.
The button appears to be working fine when placed elsewhere.

Comment 3

[Gary [:streetwolf52]]

Attachment: Add-ons InspectorWidget and Textarea Cache

This is how the icons look without hovering or selected on the Nav bar.  Notice the gray bar in front of the drop down arrows. If these icons are placed on the Bookmark toolbar, hovering over them produces a connected border(the gray line?) for the icon and arrow.

Comment 4

[Gary [:streetwolf52]]

Attachment: Arrow border does not line up with icon border.

Icon was hovered over.

Comment 5

[Gary [:streetwolf52]]

Attachment: Hover over arrow

Hovering over the arrow results in this.

Comment 6

[Girish Sharma [:Optimizer]]

(In reply to Gary [:_Dexter_] from comment #4)
> Created attachment 608373 [details]
> Arrow border does not line up with icon border.
> 
> Icon was hovered over.

So icon mode menu-button type toolbarbutton are also broken.

Comment 7

[Gary [:streetwolf52]]

(In reply to Girish Sharma from comment #6)
> (In reply to Gary [:_Dexter_] from comment #4)
> > Created attachment 608373 [details]
> > Arrow border does not line up with icon border.
> > 
> > Icon was hovered over.
> 
> So icon mode menu-button type toolbarbutton are also broken.

Seems so.

I've also seen icons on the Nav bar where the height on the hover frame is way to high.  Again these are toolbarbuttons.

Comment 8

[Girish Sharma [:Optimizer]]

(In reply to Gary [:_Dexter_] from comment #7)
> I've also seen icons on the Nav bar where the height on the hover frame is
> way to high.  Again these are toolbarbuttons.

I have filed bug 738320 for that.

Comment 9

[Gary [:streetwolf52]]

Just wanted to add that I have lots of toolbar icons on the Nav bar with dropdowns that are in one frame when hovered.  The two icons I took screenshots of are exceptions.

Comment 10

[u428464]

The download arrow button seems to be broken too with the implementation of the new download manager.

Comment 11

[Matthew N. [:MattN]]

Girish, is this still a problem? i.e. is there something we(=Firefox) could be doing to make these buttons work better by default in extensions?

Comment 12

[Girish Sharma [:Optimizer]]

I have no idea now. Wow this bug is 2 years old...