738320 - bug 735691 breaks top and bottom margin/padding of non Firefox buttons

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Girish Sharma [:Optimizer]]

Since according to bug 735691, the nav-bar buttons have padding-top and bottom set to them (I think for easier accessibility), any non Firefox button also has margin-top/bottom 0 and it stretches vertically to cover the navigation toolbar.
This looks ugly as these buttons' hover state is the old one only which appears to be stretched as compared to the hover state of Home button or any other nav-bar button.

A possible solution : Provide/allow the same class to be applied to these non Firefox buttons which is applied to nav-bar buttons. Or check and apply margins to non firefox buttons on nav-bar.

Comment 1

[Dão Gottwald [:dao]]

> A possible solution : Provide/allow the same class to be applied to these
> non Firefox buttons which is applied to nav-bar buttons.

We have that: toolbarbutton-1

Comment 2

[Girish Sharma [:Optimizer]]

So you want all Nightly users to wait till the extensions' creators do not add that class manually, which may not happen until this version goes public (16 weeks later).

Also, is the class toolbarbutton-1 available outside the nav-bar ?

Comment 3

[Dão Gottwald [:dao]]

We style toolbarbutton-1 differently on the nav-bar, the tabs toolbar and the add-on bar.

Extensions need to add the class if they want to get the custom toolbar button look. This isn't new -- the special treatment on some toolbars goes back to Firefox 4.

Comment 4

[rob64rock]

(In reply to Dão Gottwald [:dao] from comment #3)
> We style toolbarbutton-1 differently on the nav-bar, the tabs toolbar and
> the add-on bar.
> 
> Extensions need to add the class if they want to get the custom toolbar
> button look. This isn't new -- the special treatment on some toolbars goes
> back to Firefox 4.

Toolbar-buttons and those with drop-markers(default and Add-on) breakage due to having a set padding cause by bug 735691, didn't occur when the button borders were removed when using Fx small icon mode due to bug 671553. Regarding set padding issue all toolbar-button types Mozilla should follow the same path they took on bug 671553 to limit the breakage fallout for all Default and Add-on toolbar-button types.(Ex: menu, menu-button)

Dao Gottwald, what are your thoughts on why Mozilla feels it isn't necessary to prevent this type of toolbar-button breakage on bug 735691, but did so on bug 671553?

Or is there plan to have set toolbar-button paddings in Small Icon Mode as well?

Comment 5

[Dão Gottwald [:dao]]

There's no need to add padding to the buttons in small icons mode, as the whole toolbar is smaller in that mode.