738451 - Permanent orange for release builds TB 12 & later: TEST-UNEXPECTED-FAIL | test-eml-subject.js

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Test Failure: a != b: 'Mozilla Thunderbird' != 'Thunderbird'.
TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_empty_subject
TEST-START | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test_eml_normal_subject
Test Failure: a != b: 'An email - Mozilla Thunderbird' != 'An email - Thunderbird'.
TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject

The issue here is that in messenger.xul, we're using titledefault.label which equates to brandFullName, however the unit test is getting brandShortName.

This is fine for the non-official builds, but breaks when we get around to the official ones.

The fix is simple - use the right string :-)

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 608458 [details] [diff] [review]
The fix

Good catch!

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/daa0da7a8ea1

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 608458 [details] [diff] [review]
The fix

[Triage Comment]
Taking this onto branches so that we don't hit it for more releases, especially as this is a test-only change.

Comment 4

[Mark Banner (:standard8)]

Checked in:

http://hg.mozilla.org/releases/comm-aurora/rev/890343a19768
http://hg.mozilla.org/releases/comm-beta/rev/ad8f79a72aa2