Last Comment Bug 738451 - Permanent orange for release builds TB 12 & later: TEST-UNEXPECTED-FAIL | test-eml-subject.js
: Permanent orange for release builds TB 12 & later: TEST-UNEXPECTED-FAIL | tes...
Status: RESOLVED FIXED
: regression
Product: Thunderbird
Classification: Client Software
Component: Testing Infrastructure (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 14.0
Assigned To: Mark Banner (:standard8)
:
Mentors:
Depends on:
Blocks: 593321
  Show dependency treegraph
 
Reported: 2012-03-22 13:56 PDT by Mark Banner (:standard8)
Modified: 2012-03-27 01:13 PDT (History)
1 user (show)
standard8: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed


Attachments
The fix (772 bytes, patch)
2012-03-22 13:56 PDT, Mark Banner (:standard8)
mconley: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Review

Description Mark Banner (:standard8) 2012-03-22 13:56:20 PDT
Created attachment 608458 [details] [diff] [review]
The fix

Test Failure: a != b: 'Mozilla Thunderbird' != 'Thunderbird'.
TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_empty_subject
TEST-START | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test_eml_normal_subject
Test Failure: a != b: 'An email - Mozilla Thunderbird' != 'An email - Thunderbird'.
TEST-UNEXPECTED-FAIL | e:\buildbot\win32-unittest-mozmill-beta\build\mozmill\message-window\test-eml-subject.js | test-eml-subject.js::test_eml_normal_subject

The issue here is that in messenger.xul, we're using titledefault.label which equates to brandFullName, however the unit test is getting brandShortName.

This is fine for the non-official builds, but breaks when we get around to the official ones.

The fix is simple - use the right string :-)
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-03-22 13:58:50 PDT
Comment on attachment 608458 [details] [diff] [review]
The fix

Good catch!
Comment 2 Mark Banner (:standard8) 2012-03-22 14:15:11 PDT
Checked in: http://hg.mozilla.org/comm-central/rev/daa0da7a8ea1
Comment 3 Mark Banner (:standard8) 2012-03-27 00:53:02 PDT
Comment on attachment 608458 [details] [diff] [review]
The fix

[Triage Comment]
Taking this onto branches so that we don't hit it for more releases, especially as this is a test-only change.

Note You need to log in before you can comment on or make changes to this bug.