Closed Bug 738527 Opened 12 years ago Closed 12 years ago

Syntax error breaks removing closed tabs

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(firefox13 fixed, firefox14 fixed)

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The code throws an exception and the tab is not completely destroyed or removed from the BrowserApp.tabs array. This patch fixes it.
Attachment #608562 - Flags: review?(wjohnston)
Blocks: 697309
Attachment #608562 - Flags: review?(wjohnston) → review+
*rages against the insanity of using javascript for critical components*
Please can you set the target milestone + assignee when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/563021526711
Assignee: nobody → mark.finkle
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: