add mozglue for gonk

RESOLVED FIXED in mozilla14

Status

()

Core
mozglue
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Trunk
mozilla14
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

5.74 KB, patch
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 608621 [details] [diff] [review]
patch
Assignee: nobody → gal
Comment on attachment 608621 [details] [diff] [review]
patch

Review of attachment 608621 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7274,3 @@
>      fi
> +    WRAP_LDFLAGS="${WRAP_LDFLAGS} -Wl,--wrap=getaddrinfo,--wrap=freeaddrinfo,--wrap=gai_strerror"
> +    WRAP_LDFLAGS="${WRAP_LDFLAGS} -Wl,--wrap=fork,--wrap=pthread_atfork"

Do you really want to also wrap getaddrinfo, etc.?

::: mozglue/build/Makefile.in
@@ +96,5 @@
> +# To properly wrap jemalloc's pthread_atfork call.
> +EXTRA_DSO_LDOPTS += -Wl,--wrap=pthread_atfork
> +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,android,$(DEPTH)/other-licenses/android)
> +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,gonk,../gonk)
> +endif

Please share this with android.

::: mozglue/gonk/GonkGlue.cpp
@@ +31,5 @@
> + * and other provisions required by the GPL or the LGPL. If you do not delete
> + * the provisions above, a recipient may use your version of this file under
> + * the terms of any one of the MPL, the GPL or the LGPL.
> + *
> + * ***** END LICENSE BLOCK ***** */

Please use MPL2 header.

@@ +80,5 @@
> +      if (it->parent)
> +        it->parent();
> +  }
> +  return pid;
> +}

Please move that under mozglue/build, remove the mozglue/android/APKOpen.cpp corresponding code, and make both android and gonk build from mozglue/build.
Attachment #608621 - Flags: review-
Blocks: 737084
(Assignee)

Comment 3

5 years ago
Can we do some of this as follow-up fixes? The jemalloc landing broke our builds and our build host is burning. And yes we want to wrap getaddrinfo etc hence the libandroid import.
(In reply to Andreas Gal :gal from comment #3)
> Can we do some of this as follow-up fixes? The jemalloc landing broke our
> builds and our build host is burning. And yes we want to wrap getaddrinfo
> etc hence the libandroid import.

Ok. Please change the license boilerplate, though.
(Assignee)

Comment 5

5 years ago
Will change boilerplate and land and file follow-up. Thanks. Can you stamp with these conditions?
Attachment #608621 - Flags: review- → review+
(Assignee)

Comment 6

5 years ago
Created attachment 608624 [details] [diff] [review]
patch
Attachment #608621 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #608624 - Attachment is patch: true
(Assignee)

Updated

5 years ago
Blocks: 738561
(Assignee)

Updated

5 years ago
No longer blocks: 738561
(Assignee)

Comment 7

5 years ago
Pushed to inbound. Follow-up filed. MPL2 header fixed.

http://hg.mozilla.org/integration/mozilla-inbound/rev/fd2c598e7fde
Wait!

The mozglue/gonk/Makefile.in has C++ comment syntax in it instead of Makefile # comments!
(Assignee)

Comment 9

5 years ago
mwu will fix in follow-up, we wanted to stop the builder from burning
Mode header is wrong too (C++ instead of Makefile), which screws things up massively in emacs.
(Assignee)

Comment 11

5 years ago
Please take this to the follow-up bug
(Assignee)

Updated

5 years ago
Depends on: 738561
https://hg.mozilla.org/mozilla-central/rev/fd2c598e7fde
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.