Last Comment Bug 738559 - add mozglue for gonk
: add mozglue for gonk
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: mozglue (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Andreas Gal :gal
:
Mentors:
Depends on: 738561
Blocks: 737084
  Show dependency treegraph
 
Reported: 2012-03-23 00:14 PDT by Andreas Gal :gal
Modified: 2012-03-24 14:13 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (7.84 KB, patch)
2012-03-23 00:15 PDT, Andreas Gal :gal
mh+mozilla: review+
Details | Diff | Review
patch (5.74 KB, patch)
2012-03-23 00:35 PDT, Andreas Gal :gal
no flags Details | Diff | Review

Description Andreas Gal :gal 2012-03-23 00:14:39 PDT

    
Comment 1 Andreas Gal :gal 2012-03-23 00:15:27 PDT
Created attachment 608621 [details] [diff] [review]
patch
Comment 2 Mike Hommey [:glandium] 2012-03-23 00:24:28 PDT
Comment on attachment 608621 [details] [diff] [review]
patch

Review of attachment 608621 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7274,3 @@
>      fi
> +    WRAP_LDFLAGS="${WRAP_LDFLAGS} -Wl,--wrap=getaddrinfo,--wrap=freeaddrinfo,--wrap=gai_strerror"
> +    WRAP_LDFLAGS="${WRAP_LDFLAGS} -Wl,--wrap=fork,--wrap=pthread_atfork"

Do you really want to also wrap getaddrinfo, etc.?

::: mozglue/build/Makefile.in
@@ +96,5 @@
> +# To properly wrap jemalloc's pthread_atfork call.
> +EXTRA_DSO_LDOPTS += -Wl,--wrap=pthread_atfork
> +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,android,$(DEPTH)/other-licenses/android)
> +SHARED_LIBRARY_LIBS += $(call EXPAND_LIBNAME_PATH,gonk,../gonk)
> +endif

Please share this with android.

::: mozglue/gonk/GonkGlue.cpp
@@ +31,5 @@
> + * and other provisions required by the GPL or the LGPL. If you do not delete
> + * the provisions above, a recipient may use your version of this file under
> + * the terms of any one of the MPL, the GPL or the LGPL.
> + *
> + * ***** END LICENSE BLOCK ***** */

Please use MPL2 header.

@@ +80,5 @@
> +      if (it->parent)
> +        it->parent();
> +  }
> +  return pid;
> +}

Please move that under mozglue/build, remove the mozglue/android/APKOpen.cpp corresponding code, and make both android and gonk build from mozglue/build.
Comment 3 Andreas Gal :gal 2012-03-23 00:26:52 PDT
Can we do some of this as follow-up fixes? The jemalloc landing broke our builds and our build host is burning. And yes we want to wrap getaddrinfo etc hence the libandroid import.
Comment 4 Mike Hommey [:glandium] 2012-03-23 00:29:18 PDT
(In reply to Andreas Gal :gal from comment #3)
> Can we do some of this as follow-up fixes? The jemalloc landing broke our
> builds and our build host is burning. And yes we want to wrap getaddrinfo
> etc hence the libandroid import.

Ok. Please change the license boilerplate, though.
Comment 5 Andreas Gal :gal 2012-03-23 00:31:53 PDT
Will change boilerplate and land and file follow-up. Thanks. Can you stamp with these conditions?
Comment 6 Andreas Gal :gal 2012-03-23 00:35:46 PDT
Created attachment 608624 [details] [diff] [review]
patch
Comment 7 Andreas Gal :gal 2012-03-23 00:44:29 PDT
Pushed to inbound. Follow-up filed. MPL2 header fixed.

http://hg.mozilla.org/integration/mozilla-inbound/rev/fd2c598e7fde
Comment 8 David Flanagan [:djf] 2012-03-23 10:07:23 PDT
Wait!

The mozglue/gonk/Makefile.in has C++ comment syntax in it instead of Makefile # comments!
Comment 9 Andreas Gal :gal 2012-03-23 10:55:35 PDT
mwu will fix in follow-up, we wanted to stop the builder from burning
Comment 10 Kyle Machulis [:kmachulis] [:qdot] 2012-03-23 11:24:23 PDT
Mode header is wrong too (C++ instead of Makefile), which screws things up massively in emacs.
Comment 11 Andreas Gal :gal 2012-03-23 11:29:07 PDT
Please take this to the follow-up bug
Comment 12 Ed Morley [:emorley] 2012-03-24 14:13:25 PDT
https://hg.mozilla.org/mozilla-central/rev/fd2c598e7fde

Note You need to log in before you can comment on or make changes to this bug.