Closed Bug 738589 Opened 13 years ago Closed 13 years ago

JavaScript strict warning in viewSourceUtils.js

Categories

(Toolkit :: View Source, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

(Keywords: helpwanted)

Attachments

(1 file)

Warning: octal literals and octal escape sequences are deprecated
Source File: chrome://global/content/viewSourceUtils.js
Line: 251, Column: 55
Source Code:
>foStream.init(this.file, 0x02 | 0x08 | 0x20, 0664, 0); // write | create | truncate
>                                             ^

Does anyone have any objection to changing this to -1?
cf bug 532369
Blocks: 737022, fx-noise
(In reply to neil@parkwaycc.co.uk from comment #0)
> Does anyone have any objection to changing this to -1?

do it!
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #610505 - Flags: review?(gavin.sharp)
Attachment #610505 - Flags: review?(gavin.sharp) → review+
Pushed changeset ba43d5d6a6c3 to mozilla-central.
No longer blocks: 737022
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: