Last Comment Bug 738705 - Remove dead class CompareByContentOrderComparator in nsFrameList
: Remove dead class CompareByContentOrderComparator in nsFrameList
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Daniel Holbert [:dholbert]
:
Mentors:
Depends on: 556446
Blocks: deadcode
  Show dependency treegraph
 
Reported: 2012-03-23 10:51 PDT by Daniel Holbert [:dholbert]
Modified: 2012-03-24 13:59 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1 (1.62 KB, patch)
2012-03-23 10:53 PDT, Daniel Holbert [:dholbert]
bzbarsky: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-03-23 10:51:48 PDT
Bug 556446 (a dead-code removal bug) removed the last usage of CompareByContentOrderComparator / CompareByContentOrder in nsFrameList.cpp, but it left those two pieces of now-dead code behind.

Filing this bug on removing them.
Comment 1 Daniel Holbert [:dholbert] 2012-03-23 10:53:45 PDT
Created attachment 608769 [details] [diff] [review]
fix v1
Comment 2 Boris Zbarsky [:bz] 2012-03-23 10:57:37 PDT
Comment on attachment 608769 [details] [diff] [review]
fix v1

r=me
Comment 3 Daniel Holbert [:dholbert] 2012-03-23 11:22:42 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/682c5137c710
Comment 4 Ed Morley [:emorley] 2012-03-24 13:59:02 PDT
https://hg.mozilla.org/mozilla-central/rev/682c5137c710

Note You need to log in before you can comment on or make changes to this bug.