Closed Bug 738929 Opened 8 years ago Closed 8 years ago

Speed up building of layout/svg/base/src by cleaning up #include directives in its source files

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Whiteboard: [include-what-you-use])

Attachments

(1 file)

Attached patch patchSplinter Review
Following on from bug 721131, this patch cleans up the headers in the source files in layout/svg/base/src. The build time is only cut by 2% this time.
Attachment #609008 - Flags: review?(dholbert)
Blocks: 738969
Comment on attachment 609008 [details] [diff] [review]
patch

>+// Keep in (case insensitive) order:

Extreme nit, which I'm only mentioning because this comment may end up appearing across a significant fraction of the codebase if these bugs take off, and it'd be nice to be consistent:

I believe "case-insensitive" (with a hyphen) is more commonly-accepted (/ correct?) than "case insensitive" (no hyphen). For what it's worth, https://en.wikipedia.org/wiki/Case_sensitivity has it hyphenated, and there's a section on the "Talk" page discussing this very question: https://en.wikipedia.org/wiki/Talk:Case_sensitivity#hyphen-sensitive

It doesn't really matter, but if you agree & feel like doing a search-and-replace across the patch, I wouldn't complain. :)
Attachment #609008 - Flags: review?(dholbert) → review+
Sure thing, I made that change and pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/78e3ec2adbdf
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/78e3ec2adbdf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.