Last Comment Bug 738957 - nsMathMLForeignFrameWrapper class and related files are dead
: nsMathMLForeignFrameWrapper class and related files are dead
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: MathML (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Ehren Metcalfe
:
Mentors:
Depends on:
Blocks: deadcode
  Show dependency treegraph
 
Reported: 2012-03-24 11:25 PDT by Ehren Metcalfe
Modified: 2012-08-09 08:21 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (10.04 KB, patch)
2012-03-24 11:29 PDT, Ehren Metcalfe
karlt: review+
Details | Diff | Splinter Review
patch for checkin (11.14 KB, patch)
2012-03-25 15:10 PDT, Ehren Metcalfe
ehren.m: review+
Details | Diff | Splinter Review

Description Ehren Metcalfe 2012-03-24 11:25:09 PDT
Here's an MXR search: http://mxr.mozilla.org/mozilla-central/search?string=nsMathMLForeignFrameWrapper
Comment 1 Ehren Metcalfe 2012-03-24 11:29:40 PDT
Created attachment 609020 [details] [diff] [review]
patch

(tested on linux)
Comment 2 Karl Tomlinson (:karlt) 2012-03-25 14:35:36 PDT
Comment on attachment 609020 [details] [diff] [review]
patch

Thanks.
Can you remove the declaration for the removed function NewMathMLForeignFrameWrapper too, please?
http://hg.mozilla.org/mozilla-central/annotate/3e4735893504/layout/mathml/nsMathMLParts.h#l46
Comment 3 Ehren Metcalfe 2012-03-25 15:10:23 PDT
Created attachment 609163 [details] [diff] [review]
patch for checkin

no prob.

(carrying over r+)
Comment 4 Ehren Metcalfe 2012-03-25 16:36:45 PDT
Comment on attachment 609163 [details] [diff] [review]
patch for checkin

(sry for the spam. checkin flag is new to me)
Comment 6 Matt Brubeck (:mbrubeck) 2012-03-26 11:29:55 PDT
This patch has landed in mozilla-central and will be included in tomorrow's nightly build.  Thanks!

https://hg.mozilla.org/mozilla-central/rev/3018a98a65b2

Note You need to log in before you can comment on or make changes to this bug.