Closed Bug 739188 Opened 8 years ago Closed 8 years ago

Allow crosscompiling for Windows without NSIS

Categories

(Firefox Build System :: General, defect)

All
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: jacek, Assigned: jacek)

References

Details

(Keywords: regression)

Attachments

(2 files)

Attached patch fix v1.0Splinter Review
From bug 604266 comment 28:

The patch removing --disable-installer broke cross compilation. Ideally, cross compiling installer should be fixed. I've tried playing with that. nsis seems prepared for this. It has POSIX version that produces win32 binaries. Sadly, the Unicode NSIS fork totally broke this ability.

That's why I think the solution is to make it still possible to compile without installer, but limit the code it affects so that it doesn't complicate supported configurations. The attached patch does it by making lack of Unicode NSIS not critical when cross compiling (this way no configure option is needed). Also, instead of using MOZ_INSTALLER, it uses MAKENSISU variable in a few makefile-related places, so that MOZ_INSTALLER can still be removed.


Attaching fixed patch.
Blocks: 604266
Could you attach a "diff -w" too, to ease review?
Keywords: regression
OS: Linux → Windows XP
Hardware: x86_64 → All
Attached patch diff -wSplinter Review
Sure. I usually use git, trying to make the diff as similar to hg as possible, but I'm not sure how to emulate diff -w. The attached patch is produced by |hg diff -w| from plain mercurial repository.

I'm waiting with r? for try results:
https://tbpl.mozilla.org/?tree=Try&rev=b0833861ede4
Comment on attachment 609290 [details] [diff] [review]
fix v1.0

Succeeded on try
Attachment #609290 - Flags: review?(sgautherie.bz)
Try run for b0833861ede4 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=b0833861ede4
Results (out of 2 total builds):
    success: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jacek@codeweavers.com-b0833861ede4
Comment on attachment 609290 [details] [diff] [review]
fix v1.0

Serge is not a Firefox build config peer, redirecting to kyle
Attachment #609290 - Flags: review?(sgautherie.bz) → review?(khuey)
Comment on attachment 609290 [details] [diff] [review]
fix v1.0

Redirecting assuming you want this reviewed before May.
Attachment #609290 - Flags: review?(khuey) → review?(ted.mielczarek)
Comment on attachment 609290 [details] [diff] [review]
fix v1.0

Review of attachment 609290 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine for now. Kind of unfortunate that you don't have a working makesnsisu for cross-compiling :-/
Attachment #609290 - Flags: review?(ted.mielczarek) → review+
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/6e232128a8ca
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.