741340 - Port |Bug 739188 - Allow crosscompiling for Windows without NSIS| to comm-central

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect, P3)

Comment 1

[Nicolas Vigier]

Attachment: proposed patch

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8532941 [details] [diff] [review]
proposed patch

Review of attachment 8532941 [details] [diff] [review]:
-----------------------------------------------------------------

This looks sane, but we should have a real build peer look at it (and a SM peer).

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8532941 [details] [diff] [review]
proposed patch

Review of attachment 8532941 [details] [diff] [review]:
-----------------------------------------------------------------

if joshua gives this r+ thats all I need to trust it for SeaMonkey

Comment 4

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/b3f8c6613ab0 -> FIXED