Closed Bug 741340 Opened 9 years ago Closed 6 years ago

Port |Bug 739188 - Allow crosscompiling for Windows without NSIS| to comm-central

Categories

(MailNews Core :: Build Config, defect, P3)

All
Windows XP
defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 37.0

People

(Reporter: sgautherie, Assigned: boklm)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
Attached patch proposed patchSplinter Review
Attachment #8532941 - Flags: review?(clokep)
Comment on attachment 8532941 [details] [diff] [review]
proposed patch

Review of attachment 8532941 [details] [diff] [review]:
-----------------------------------------------------------------

This looks sane, but we should have a real build peer look at it (and a SM peer).
Attachment #8532941 - Flags: review?(clokep)
Attachment #8532941 - Flags: review?(bugspam.Callek)
Attachment #8532941 - Flags: review?(Pidgeot18)
Attachment #8532941 - Flags: review+
Comment on attachment 8532941 [details] [diff] [review]
proposed patch

Review of attachment 8532941 [details] [diff] [review]:
-----------------------------------------------------------------

if joshua gives this r+ thats all I need to trust it for SeaMonkey
Attachment #8532941 - Flags: review?(bugspam.Callek)
Assignee: nobody → boklm
Status: NEW → ASSIGNED
Target Milestone: Thunderbird 14.0 → ---
Attachment #8532941 - Flags: review?(Pidgeot18) → review+
https://hg.mozilla.org/comm-central/rev/b3f8c6613ab0 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 37.0
Depends on: 1115018
You need to log in before you can comment on or make changes to this bug.