739250 - amo-validator: UnboundLocalError: local variable 'max_ver_pos' referenced before assignment

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Add-on Validation, defect, P1)

Description

[Kumar McMillan [:kumar]]

This is happening in prod:

Traceback (most recent call last):
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/execute/trace.py", line 34, in trace
   return cls(states.SUCCESS, retval=fun(*args, **kwargs))
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/task/base.py", line 241, in __call__
   return self.run(*args, **kwargs)
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/app/__init__.py", line 141, in run
   return fun(*args, **kwargs)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/nuggets/celeryutils.py", line 35, in wrapped
   return fun(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 112, in wrapper
   return f(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 104, in wrapper
   return f(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/devhub/tasks.py", line 45, in validator
   result = run_validator(upload.path)
 File "/data/www/addons.mozilla.org/zamboni/apps/devhub/tasks.py", line 154, in run_validator
   timeout=settings.VALIDATOR_TIMEOUT)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/validate.py", line 47, in validate
   timeout=timeout)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 91, in prepare_package
   for_appversions)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 171, in test_package
   output = test_inner_package(err, package, for_appversions)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 346, in test_inner_package
   test_func(err, xpi_package)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/targetapplication.py", line 133, in test_targetedapplications
   app_versions[min_ver_pos:max_ver_pos + 1]
UnboundLocalError: local variable 'max_ver_pos' referenced before assignment

Comment 1

[Matt Basta [:basta]]

Can you attach the add-on that this is happening for?

Comment 2

[Kumar McMillan [:kumar]]

Attachment: xpi causing traceback

Comment 3

[Matt Basta [:basta]]

This is somewhat because of an ambiguity in the install manifest spec. I've updated the spec to be more specific about which elements are required and will push a patch shortly.

Comment 4

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/amo-validator/pull/149

Comment 5

[Wraithan (Chris McDonald) [:wraithan]]

Merged:

https://github.com/mozilla/amo-validator/commit/7ea3d1bf6acd15df19cad3afd35bb61e2d2a3788