739591 - Implement filter xlink:href

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Should be able to link filters via xlink:href so that any attributes which are defined on the referenced ‘filter’ element which are not defined on the current element are inherited.

We already implement this for gradients and patterns and the new code follows the approach taken there.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch with reftest

Comment 2

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/24b7f6c27ee1

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 609706 [details] [diff] [review]
patch with reftest

Review of attachment 609706 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/svg/base/src/nsSVGFilterFrame.cpp
@@ +304,5 @@
> +nsSVGFilterFrame::GetFilterContent(nsIContent *aDefault)
> +{
> +  PRUint32 count = mContent->GetChildCount();
> +  for (PRUint32 i = 0; i < count; ++i) {
> +    nsIContent* child = mContent->GetChildAt(i);

This will be O(n^2) once we remove the array-based storage... We've been working to remove this pattern in favour of

for (nsIContent* child = mContent->GetFirstChild();
     child;
     child = child->GetNextSibling())

Comment 4

[Robert Longson [:longsonr]]

(In reply to Ms2ger from comment #3)
Probably best to raise another bug so that http://mxr.mozilla.org/mozilla-central/source/layout/svg/base/src/nsSVGFilterInstance.cpp#202 can be addressed too.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/24b7f6c27ee1