739972 - Stop using GetChildAt in svg layout

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

See bug 739591 comment 3

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 610116 [details] [diff] [review]
patch

Great, thanks a lot!

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 610116 [details] [diff] [review]
patch

>+++ b/layout/svg/base/src/nsSVGFilterInstance.cpp
>@@ -194,34 +194,33 @@ nsSVGFilterInstance::BuildSources()
>   return NS_OK;
> }
> 
> nsresult
> nsSVGFilterInstance::BuildPrimitives()
> {
>   // First build mFilterInfo. It's important that we don't change that
>   // array after we start storing pointers to its elements!
>-  PRUint32 count = mFilterElement->GetChildCount();
>-  PRUint32 i;
>-  for (i = 0; i < count; ++i) {
>-    nsIContent* child = mFilterElement->GetChildAt(i);
>+  for (nsIContent* child = mFilterElement->nsINode::GetFirstChild();
>+      child;
>+      child = child->GetNextSibling()) {

Nit: those last 2 lines need 1 more space of indentation.

r=me with that fixed.

Comment 4

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/55a95cfe5ab9

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/55a95cfe5ab9