layout/reftests/canvas have 16 tests that fail on android

RESOLVED FIXED

Status

()

Core
Canvas: 2D
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jmaher, Assigned: jet)

Tracking

Trunk
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
On android xul, we run with e10s and our reftest harness will setup the xul window to have the remote=true attribute.  For native fennec we have the preference to turn on e10s set, but we don't read it.  This means that reftest is still thinking we are remote, but in reality we are not.  

In trying to turn this off, I found that we have 16 tests which pass on android-xul, but are failing now on native with the browser.tabs.remote pref turned off.

The log file showing this is here:
http://people.mozilla.org/~jmaher/android_reftests/canvas.log
Blocks: 739711
(Reporter)

Comment 1

5 years ago
Can we get somebody to look at this bug?  This might knock out half of our failing reftests by figuring out why these canvas tests are failing.
(In reply to Joel Maher (:jmaher) from comment #1)
> Can we get somebody to look at this bug?  This might knock out half of our
> failing reftests by figuring out why these canvas tests are failing.

Jet?
Assignee: nobody → jet
I'm not eager to jump into this (I don't have a mobile build config right now), but for the record, the failing tests from comment 0 are:
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/size-1.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/image-shadow.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/size-change-1.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-ltr-left.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-ltr-right.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-rtl-left.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-rtl-right.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-ltr-left.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-rtl-left.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-big-stroke.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-big-stroke.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/text-bidi-ltr-test.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/linear-gradient-1a.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/linear-gradient-1b.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/evenodd-fill-1.html 
http://mxr.mozilla.org/mozilla-central/source/layout/reftests/canvas/693610-1.html 

See also the tests listed in bug 739711 comment 1. (which appear to be failing for the same reason)
No longer blocks: 739711
Duplicate of this bug: 739711
(Reporter)

Comment 5

5 years ago
can we get somebody to look at this?

Updated

5 years ago
Blocks: 748088
(Reporter)

Comment 6

5 years ago
I am going to mark the manifest file as failing on android&&browserIsRemote.  This is the XUL case only.  As this passes on Android Native and we are focused on Native development I vote for closing this bug as wont fix.
(Assignee)

Comment 7

5 years ago
Please add the relevant check-in for the manifest file, then close this one. Thanks!
(Reporter)

Comment 8

5 years ago
ok, I mixed these up with another test, these tests are in parity for failing both on android xul and native!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Reporter)

Comment 9

5 years ago
ok, reopening this as per discussion in irc with :dholbert.  We should figure out why these tests fail in general on Android which is different from the original intention of the bug to figure out why we are getting different results between xul and native.
No longer blocks: 732494, 732498, 748088
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: layout/reftests/canvas have 16 tests that fail on android when we turn browser.tabs.remote=false → layout/reftests/canvas have 16 tests that fail on android
jmaher, is this still an issue?  This bug is still open, and yet it doesn't look like these tests have been flagged as failing. Are they still causing trouble anywhere?
(Reporter)

Comment 11

5 years ago
these are running on both xul and native android fennec builds and appear to be passing.  this snuck through the cracks.
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.