739715 - [traceback] AttributeError: 'NoneType' object has no attribute 'get_literal_value'

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

These are the exceptions which oremj seems before validation hangs-

http://oremj.pastebin.mozilla.org/1538519

Comment 1

[Christopher Van Wiemeersch [:cvan]]

Full traceback:

Task devhub.tasks.validator with id bb1b46df-8ce1-4658-b4f5-85e5372ea9d6 raised exception:
'AttributeError("\'NoneType\' object has no attribute \'get_literal_value\'",)'


Task was called with args: ('a0ebc92460a5436ba996dfabb92f3192',) kwargs: {}.

The contents of the full traceback was:

Traceback (most recent call last):
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/execute/trace.py", line 34, in trace
   return cls(states.SUCCESS, retval=fun(*args, **kwargs))
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/task/base.py", line 241, in __call__
   return self.run(*args, **kwargs)
 File "/data/www/addons.mozilla.org/zamboni/vendor/lib/python/celery/app/__init__.py", line 141, in run
   return fun(*args, **kwargs)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/nuggets/celeryutils.py", line 35, in wrapped
   return fun(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 112, in wrapper
   return f(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/amo/decorators.py", line 104, in wrapper
   return f(*args, **kw)
 File "/data/www/addons.mozilla.org/zamboni/apps/devhub/tasks.py", line 45, in validator
   result = run_validator(upload.path)
 File "/data/www/addons.mozilla.org/zamboni/apps/devhub/tasks.py", line 154, in run_validator
   timeout=settings.VALIDATOR_TIMEOUT)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/validate.py", line 47, in validate
   timeout=timeout)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 91, in prepare_package
   for_appversions)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 171, in test_package
   output = test_inner_package(err, package, for_appversions)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/submain.py", line 346, in test_inner_package
   test_func(err, xpi_package)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/content.py", line 239, in test_packed_scripts
   pollutable=reversed_script in marked_scripts)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/scripting.py", line 58, in test_js_file
   t.run(tree)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 63, in run
   self._traverse_node(data)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 169, in _traverse_node
   map(self._traverse_node, b)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 477, in _expression
   result = traverser._traverse_node(node["expression"])
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 538, in _expr_assignment
   right = traverser._traverse_node(node["right"])
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 306, in _define_obj
   var_value = traverser._traverse_node(prop["value"])
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 179, in _func_expr
   results = _function(traverser, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 154, in _function
   traverser._traverse_node(node["body"])
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 169, in _traverse_node
   map(self._traverse_node, b)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 477, in _expression
   result = traverser._traverse_node(node["expression"])
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/traverser.py", line 147, in _traverse_node
   action_result = action(self, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 566, in _expr_assignment
   instantiate=True)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 70, in trace_member
   identifier = _get_member_exp_property(traverser, node)
 File "/data/www/addons.mozilla.org/zamboni/vendor/src/amo-validator/validator/testcases/javascript/actions.py", line 20, in _get_member_exp_property
   return _get_as_str(eval_exp.get_literal_value())
AttributeError: 'NoneType' object has no attribute 'get_literal_value'

Comment 2

[Kumar McMillan [:kumar]]

Attachment: xpi to reproduce traceback

Comment 4

[Kumar McMillan [:kumar]]

still seeing this a lot in prod, bumping to P1

Comment 5

[Michel Verbraak]

Is there another way to add my add-on to the repository. Because currently this is not possible and I have a lot of bugs fixed so end users are waiting for it. (see bug 740255)

Regards.

Comment 6

[Wil Clouser [:clouserw]]

(In reply to Michel Verbraak from comment #5)
> Is there another way to add my add-on to the repository. Because currently
> this is not possible and I have a lot of bugs fixed so end users are waiting
> for it. (see bug 740255)
> 
> Regards.

Not right now but I should have an ETA on this bug soon.

Comment 7

[Matt Basta [:basta]]

Fixed and merged:

https://github.com/mozilla/amo-validator/pull/136

Comment 8

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/developers/upload/42c53d54fab44de7b4a0bede006b6b50