739794 - change how we specify the index name for elasticsearch

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

On dev and stage, ES_INDEXES is specified in settings_local.py which is not in our repository and thus we don't have a way of updating it. Because of that, our read/write indexing thing doesn't work.

elasticutils get_es() uses ES_INDEXES as the default index. When you create an S, you pass in a model and it looks at ES_INDEXES[model._meta.db_table] to derive the index it's going to fiddle with.

Thus this creates the problem where we can't effectively specify the index to use in the settings.py file and we'd need additional access to change things.

One possible solution is to change things so that instead of ES_INDEXES and ES_WRITE_INDEXES having to start with ES_INDEX_PREFIX, we instead prepend ES_INDEX_PREFIX to ES_INDEXES and ES_WRITE_INDEXES. Then dev and stage can specify ES_INDEX_PREFIX and we can change the settings as we need to.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

I think this is a 1pter. It requires changes to elasticutils, but should otherwise be pretty easy to do.

Assigning it to myself.

If it doesn't get done in 2012.6, then it should get done in 2012.7. Without this we can't do any reindex-requiring elasticsearch code changes after we ditch Sphinx.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1 because it blocks removing Sphinx.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

https://github.com/mozilla/kitsune/pull/564

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is all set. Pushing it to production is blocking on two things:

1. Cww is supposed to be doing CTR/metrics for the search results changes. I need to coordinate with him to make sure pushing to production (which will require us to switch to Sphinx for a couple of hours) is ok.

2. We need IT to change ES_INDEX_PREFIX on -dev and -stage. It's fine on prod.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/76638283e619ea7ecc81179aadd3b1f451c24d47

Pushed to production this morning.