Closed
Bug 73982
Opened 25 years ago
Closed 25 years ago
add image pre-caching to mac classic skin xbl
Categories
(SeaMonkey :: Themes, defect, P2)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9.1
People
(Reporter: andreww, Assigned: andreww)
References
Details
Attachments
(5 files)
now that libpr0n is in and pre-caching seems to work - we need to add the
<resources><image> etc. tags to many buttons to improve their responsiveness
Themes Triage Team Marking nsbeta1+
Shifting to .9.1 - I'm still seeing problems with images being cached but
seemingly not being utilized. Need a bit more time to hash out the issues.
Target Milestone: mozilla0.9 → mozilla0.9.1
ok finally got it finished in my local build - now I just need to get it into my
tree and Ill post diffs here.
working earnestly to get this done and ready before tree closure...
| Assignee | ||
Comment 10•25 years ago
|
||
explaination of the patch:
History:
Hyatt added functionality to XBL to allow images and other resources to be placed
directly into cache on a low-priority thread. This is done via the <resources>
tag in XBL.
Mac toolbar buttons "flash" when you 1st roll over them or click on them. This is
due to the fact that the images are fetched right then, and there's an instant
where the old image is gone but the new image hasnt "arrived".
Putting these two things together - when the images are pre-cached, you see no
button flashing effects, and it really goes a long way toward making Mac look
more professional and app-like.
How it works is like this:
Hyatt suggested that I create a <resourcebundle> tag which is set as
visibility:collapse and will serve as the anchor for the XBL bindings which
contain the <resources> tag, which contains the links to the requisite pre-cached
images. Only toolbar buttons are precached, and then only the mouseover and
mousedown states, as those are the most noticably "flashing"
This patch doesnt effect modern - which may get image pre-caching at a future
date.
Here is the path:
somename.xul --(<resourcebundle>)-->somename.css --(-moz-binding:url())-->
resources.xml
this is built with the idea that there may be future things we may want to pre-
cache - like say sounds.
Patch is ready and I'm seeking reviewers.
Keywords: review
| Assignee | ||
Comment 11•25 years ago
|
||
cc'ing some folks interested. Please review if you can.
Comment 12•25 years ago
|
||
r=pink.
i _really_ think we need this for the modern skin. Given that we want people to
use modern, making it as polished as possible will help.
we also sorely need this for the ok/cancel buttons, which is where most users
run into this problem. people look at our buttons, see the flashing, and think
the app sucks because we can't even get simple buttons right.
how hard can it be to get these two things done?
| Assignee | ||
Comment 13•25 years ago
|
||
re: modern skin - I can't speak for Joe but I'm sure once this is in for classic,
modern could follow pretty quickly.
re: ok/cancel buttons - the precaching _is_ in there (buttonbindings.xml) but the
depends bug on this one (75474) makes this still not work properly. So once that
bug is fixed, the images will be there and be precached like they need to be and
the funky partial buttons behaviour should go away, and instead behave like a
button does after it's been clicked 2X
I know the button images are being pre-cached because I can see them listed in
the about:cache view - before I ever click a button (which would have triggered
those other mousedown states of images to get loaded)
Comment 14•25 years ago
|
||
sr=hewitt
| Assignee | ||
Comment 15•25 years ago
|
||
fix checked into tree.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 16•25 years ago
|
||
Verified on mac (commercial build: 2001-06-04-08-trunk).
Status: RESOLVED → VERIFIED
Updated•18 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•