75474 - images pre-cached still "flash"

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P4)

Description

[andreww]

I added image pre-caching via XBL <resources> tag for mac OS buttons like "ok"
and "cancel" but even though they show up in the about:cache as pre-cached the
buttons still "flash" on mousedown - the very first time - as if the precached
images werent getting used properly.

Comment 1

[Stuart Parmenter]

fixed.

Comment 2

[andreww]

reopening - I still see this behavior in today's build - 2001041704

Comment 3

[andreww]

Attachment: test case for "pre caching "

Comment 4

[andreww]

explaination of test case file -
This file contains a series of buttons - each of which contains a part of the
"down" state for buttons.  This simulates the act of pre-caching these images.
Now the two images at the top are examples to "click" on.  Notice that even when
the images have been loaded as list-style-images in buttons, there still is a
"flash" the first time those buttons at the top are pressed.  Look at this in
the mac classic skin for the most pronounced effect.

Comment 5

[Terri Preston]

Due to comments in the bug, changing status to [imglib]

Comment 6

[Gagan]

this will help with preloading chrome and improve UI appearance. 

Comment 7

[Stuart Parmenter]

I'd really like to fix this for 0.9.1, but i'm not sure I will have time.. may 
have to push to 0.9.1

Comment 8

[Stuart Parmenter]

has the image preloading xbl been checked in to the tree, or is it going to be 
for 0.9.1?  if not, can I move this to 0.9.2?  If it has been checked in, or is 
ready to (assuming this bug was fixed), can we either get it in to the tree so 
I can more easily test it or send me the stuff to test it?

Comment 9

[Stuart Parmenter]

*** Bug 79552 has been marked as a duplicate of this bug. ***

Comment 10

[selmer (gone)]

Annoying, but not a stopper.  Moving to m.9.2.  Is there any answer to Pav's
question from 5/21?

Comment 11

[Håkan Waara]

It still flashes as before, even after andreww's checkin (that was supposed to
prevent that, right?)

Comment 12

[andreww]

yes, image pre-caching is checked into the tree for the following skins:
modern (all platforms)
classic (mac)

windows classic does not  have pre-caching yet. 

so as this bug states - event though the 9 piece buttons are pre-cached 
(you can see them in the about:cache view) they still will flash the first time 
they are accessed)

Comment 13

[Todd Pringle]

Pav, any updates on this one?  Andrew's checkin fixes the toolbar issues, but it
would be nice if everything worked correctly - such as dialog okay buttons and
the  profile manager buttons, which still don't seem to work properly.

Comment 14

[Stuart Parmenter]

are all images precached?  including dialog images, etc.. or just the toolbar 
ones?

Comment 15

[andreww]

mac classic has pre-caching of toolbar buttons (just hover and down 
states) and ok/cancel type buttons.

windows classic  hasnt been checked in yet.

modern has toolbar buttons pre-cached like mac classic, but the 
ok/cancel  buttons aren't being currently pre-cached due to a missing 
patch. I'm filing a new bug on myself to get that in asap.

So the best way to test this would be to use mac classic skin.  

Ill post the number of the bug for ok/cancel buttons in modern in just a 
sec.

Comment 16

[andreww]

the bug is bug 86673 -- although even when this is in... things still dont 
seem to work properly.

Comment 17

[Jason Kersey]

-> 0.9.4

Comment 18

[Markus Hübner]

is bug 92248 related to this?

Comment 19

[Stuart Parmenter]

.

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 99051 has been marked as a duplicate of this bug. ***

Comment 21

[Stuart Parmenter]

this was fixed by my checkin to not refect images multiple times