73987 - Version check for Qt

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[John Griggs]

The attached patch adds a version check for Qt to configure.  I couldn't figure
out how to add the same code to configure.in, so I have left it out for now.  If
someone else could write this (or explain to me how to do so), I'd be much
obliged.

Comment 1

[John Griggs]

Attachment: patch to add Qt version check to configure

Comment 2

[cls]

Since configure is a generated file, the proper way to do this would be to add
the check to configure.in and then run autoconf to regenerate configure.  The
version check blocks for zlib & png should be similar to what you want and you
can probably use them as a template.

Comment 3

[John Griggs]

Attachment: Qt version check Patch for configure.in

Comment 4

[John Griggs]

Attachment: Qt version check patch for configure (supercedes previous configure patch)

Comment 5

[John Griggs]

I have attached a patch for configure.in (Thanks to Chris Seawood for the
pointers on how to code this) and a replacement patch for configure that uses
the code generated from configure.in in place of the hand-coded stuff from the
original patch.  I edited the configure patch to remove diffs due to line number
changes, so it may be necessary to patch configure.in and generate configure
directly rather than patch configure...

Comment 6

[cls]

Attachment: Use AC_LANG_CPLUSPLUS for qt check.

Comment 7

[cls]

Attachment: use AC_TRY_COMPILE so we don't have to guess about the cross-compile case.

Comment 8

[cls]

Last patch checked in.  Marking fixed.

Comment 9

[saari (gone)]

*** Bug 73342 has been marked as a duplicate of this bug. ***

Comment 10

[Jon Granrose]

verified.