Closed Bug 739912 Opened 12 years ago Closed 12 years ago

Remove obsolete workaround pref editor.quotesPreformatted in TB

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set
minor

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #368758 +++

The pref  editor.quotesPreformatted  was introduced as a "temporary" hack for bug 69638.  It's used in two places:

* nsHTMLEditor::InsertAsPlaintextQuotation()
  if somehow set True, puts reply-quotes inside a <pre> rather than 
  a <span> in the plain-text editor.  No visible effect in the compose window,
  but requires an extra rule in HTML.CSS to colorize the pre[_moz_quote].

* nsPlainTextSerializer::Write()
  if True, may cause a bypass of the "no intelligent wrapping" section of the
  DOM-to-Text conversion of the plain-text editor's buffer into a message,
  thereby preventing quotes from being wrapped -- the same behavior seen when
  the pref is turned off and the quote is contained within a <span>.

The pref is set to False by default; I seriously doubt anyone still uses this for anything.  I gather it was desirable when there was some other, harder-to-deal-with problem in the editor's behavior within a <pre>, but that's obsolete now.  This pref and the code supporting it is all cruft, and should be removed.

xref bug 233705 -- the pref discussed at that bug also "bypasses the 'no intelligent wrapping'" DOM-to-text conversion.
Attachment #610038 - Flags: review+
Attachment #610038 - Flags: approval-comm-aurora?
Attachment #610038 - Flags: approval-comm-aurora? → approval-comm-aurora+
Keywords: checkin-needed
This already appears to have landed on comm-central, but I don't see the responsible changeset offhand.
Keywords: checkin-needed
(That or another patch in my massive queue made the same change)
Yes, it landed on central in bug 610038.
This patch is for aurora, see the patch flags.
Keywords: checkin-needed
Whiteboard: [checkin into aurora only]
http://hg.mozilla.org/releases/comm-aurora/rev/cb2ba44f41aa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin into aurora only]
Target Milestone: --- → Thunderbird 14.0
Thanks for the separate bug.
You need to log in before you can comment on or make changes to this bug.