739986 - Random orange: TEST-UNEXPECTED-FAIL |test-cloudfile-backend-dropbox.js | test-cloudfile-backend-dropbox.js::test_oauth_complete_causes_logout

Status: RESOLVED FIXED

(Thunderbird :: Testing Infrastructure, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

This has been showing up periodically on our Windows test machines:

TEST-PASS | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | test-cloudfile-backend-dropbox.js::teardownTest
TEST-PASS | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | test-cloudfile-backend-dropbox.js::test_create_existing_account
TEST-START | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | setupTest
TEST-PASS | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | test-cloudfile-backend-dropbox.js::setupTest
TEST-START | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | test_oauth_complete_causes_logout
Step Pass: {"function": "controller.waitFor()"}
2012-03-27 15:22:09	Dropbox	INFO	Successfully ended authorization session.
2012-03-27 15:22:09	Dropbox	INFO	Successfully ended authorization session.
Running global cleanup code from study base classes.
Test Failure: waitFor: Timeout exceeded for 'function () 1 == obs.numSightings(kLogout)'
TEST-START | e:\buildbot\comm-aurora-win32-opt-unittest-mozmill\build\mozmill\cloudfile\test-cloudfile-backend-dropbox.js | teardownTest

It looks like the "logout" request is happening twice...unsure why, but that explains the failure (since obs.numSightings(kLogout) would be 2 instead of 1).

Introduced by bug 737955.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

While I don't have any proof of this yet, I have the gut feeling that bug 740956 will fix this.

Originally, the test servers for both YouSendIt and Dropbox were returning prepared nsIMsgCloudFileProvider's via getService as opposed to createInstance.  I think that caused the tests to use the same instance again and again, which could accounts for the double logout request that causes this failure.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

I'm reasonably certain that bug 740956 fixed this on both comm-central and comm-aurora (which is where the failing tests was occurring).

Unless I see this pop up again, I'm closing this bug.