740185 - Mark safe JS context black

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8]]

This is kept alive for the lifetime of the browser, and adds 100 or so nodes to the CC graph.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: add marker to nsContentUtils, use it

I was trying to avoid adding code to nsContentUtils, but that would have required exposing the definition of nsIThreadJSContextStack to nsCCUncollectableMarker, which seems to be a somewhat private XPConnect class.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: fix if braces

Comment 3

[Andrew McCreight [:mccr8]]

Comment on attachment 610368 [details] [diff] [review]
fix if braces

Try run looked good https://tbpl.mozilla.org/?tree=Try&rev=c9baf630c73c

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 610368 [details] [diff] [review]
fix if braces


>+nsContentUtils::TraceSafeJSContext(JSTracer *aTrc)
>+{
>+  if (!sThreadJSContextStack) {
>+    return;
>+  }
>+  JSContext* cx = nsnull;
>+  sThreadJSContextStack->GetSafeJSContext(&cx);
>+  if (!cx) {
>+    return;
>+  }
>+  if (JSObject *global = JS_GetGlobalObject(cx)) {
>+    JS_CALL_OBJECT_TRACER(aTrc, global, "safe context");
>+  }
Nit, you're not consistent with *.
JSContext* but JSObject *
I prefer JSContext*

Comment 5

[Andrew McCreight [:mccr8]]

Good point.  I'm bad about that.  I changed them all to Foo*.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a60f2559489

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/mozilla-central/rev/2a60f2559489