Last Comment Bug 740187 - [Skia] Prevent the ARM implementation of memset16 from failing if count=0
: [Skia] Prevent the ARM implementation of memset16 from failing if count=0
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: George Wright (:gw280) (:gwright)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 687187 skia-android
  Show dependency treegraph
 
Reported: 2012-03-28 15:56 PDT by George Wright (:gw280) (:gwright)
Modified: 2012-03-29 08:50 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix memset (1.66 KB, patch)
2012-03-28 15:57 PDT, George Wright (:gw280) (:gwright)
matt.woodrow: review+
Details | Diff | Splinter Review

Description George Wright (:gw280) (:gwright) 2012-03-28 15:56:41 PDT
arm_memset16 in Skia segfaults if called with count=0. This has been fixed upstream in     http://codereview.appspot.com/5639051/
Comment 1 George Wright (:gw280) (:gwright) 2012-03-28 15:57:55 PDT
Created attachment 610331 [details] [diff] [review]
fix memset

Import patch from http://codereview.appspot.com/5639051/
Comment 2 Matt Woodrow (:mattwoodrow) 2012-03-28 16:14:57 PDT
Comment on attachment 610331 [details] [diff] [review]
fix memset

Review of attachment 610331 [details] [diff] [review]:
-----------------------------------------------------------------

Fine with me. 

Might be worth considering updating to the latest upstream version at some point. Hopefully doing it frequently will reduce the merging pain.
Comment 3 George Wright (:gw280) (:gwright) 2012-03-28 19:21:41 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca5328d3c661
Comment 4 Matt Brubeck (:mbrubeck) 2012-03-29 08:50:22 PDT
https://hg.mozilla.org/mozilla-central/rev/ca5328d3c661

Note You need to log in before you can comment on or make changes to this bug.