725119 - (skia-android) Get Azure/Skia content rendering working on Android

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[George Wright (:gw280) (needinfo me!)]

Tracking bug to track progress of Azure/Skia content rendering on Android

Comment 1

[George Wright (:gw280) (needinfo me!)]

Current status: content rendering works; canvas rendering works (but sometimes doesn't render if both content and canvas rendering via azure are enabled). Content rendering can be done via either basic layers or tiled thebes layers with my patches.

Fonts are proving to be problematic. I have a refactor sitting around, but there's still issues with it. Sometimes glyphs get rendered at the incorrect size, and sometimes extents are calculated at the wrong size for the glyphs being rendered. There also may be issues with unnecessary loading of font data from the disk.

Comment 2

[George Wright (:gw280) (needinfo me!)]

My git branch with my work-in-progress patches:

https://github.com/gw280/mozilla-central/commits/gwright/skia_linux

Comment 3

[Marco Castelluccio [:marco]]

George, is this related to bug 740200, or they are completely separate?

Comment 4

[George Wright (:gw280) (needinfo me!)]

They used to be fairly similar, but they're starting to diverge. Mainly that the gfxFont implementation on Linux is not the same as for Android, and Linux uses Thebes Layers and Android now uses Tiled Thebes Layers.

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

It would be fabu if the tiled thebeslayer reached consilience with non-tiled thebeslayer.  If it's a worthy optimization we should do it everywhere.

Not to unnecessarily block the work here though.  And the azure code working for one case but not the other would also be suspect.

Comment 6

[George Wright (:gw280) (needinfo me!)]

I already have azure rendering working in both cases, and support for basic thebes layers is actually r+d and ready to land.

Comment 8

[Lee Salzman [:lsalzman]]

Due to a bug/oversight, we are not actually using Skia for content at all on Android yet. Now that I figured out what was preventing Skia content from being enabled there, there are unresolved issues with reftests I need to take care of before we can go ahead with this.

Comment 9

[Lee Salzman [:lsalzman]]

Attachment: allow Skia as a content backend in gfxPlatform

This fixes the bugs that were preventing Skia from working as a content backend for Android.

Comment 10

[Lee Salzman [:lsalzman]]

Attachment: fuzz for reftests with Skia content on Android

This is mostly small fuzz adjustments and fixing cases where the skiaContent conditions overrode preexisting fails-if/skip-if cases for Android.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7083a4e7ebc0
allow Skia as a content backend in gfxPlatform. r=mchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/2bb5563041e5
fuzz for reftests with Skia content on Android. r=mchang

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7083a4e7ebc0
https://hg.mozilla.org/mozilla-central/rev/2bb5563041e5

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a8212bb139a7