Closed
Bug 740188
Opened 12 years ago
Closed 12 years ago
Screen Orientation API: implement locking
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: dev-doc-complete)
Attachments
(3 files, 3 obsolete files)
11.34 KB,
patch
|
smaug
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
3.59 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
2.81 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Basically, we want to add a lockOrientation(DOMString orientation) method to window.screen.
Attachment #610332 -
Flags: superreview?(jonas)
Attachment #610332 -
Flags: review?(bugs)
Assignee | ||
Comment 1•12 years ago
|
||
Basically, regular content will have to be fullscreen and chrome can do whatever they want.
Attachment #610336 -
Flags: superreview?(jonas)
Attachment #610336 -
Flags: review?(bugs)
Assignee | ||
Comment 2•12 years ago
|
||
Attachment #610337 -
Flags: superreview?(jonas)
Attachment #610337 -
Flags: review?(bugs)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [needs review]
Assignee | ||
Updated•12 years ago
|
Keywords: dev-doc-needed
Updated•12 years ago
|
Attachment #610332 -
Flags: review?(bugs) → review-
Comment 3•12 years ago
|
||
Comment on attachment 610336 [details] [diff] [review] Part 2 - Basic security model Use GetOwner(), no mOwner
Attachment #610336 -
Flags: review?(bugs) → review-
Comment 4•12 years ago
|
||
Comment on attachment 610337 [details] [diff] [review] Part 3 - Revert orientation when fullscreen is left Please no raw pointers which you don't clear ever.
Attachment #610337 -
Flags: review?(bugs) → review-
Assignee | ||
Comment 5•12 years ago
|
||
Attachment #610332 -
Attachment is obsolete: true
Attachment #610332 -
Flags: superreview?(jonas)
Attachment #610415 -
Flags: superreview?(jonas)
Attachment #610415 -
Flags: review?(bugs)
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #610336 -
Attachment is obsolete: true
Attachment #610336 -
Flags: superreview?(jonas)
Attachment #610416 -
Flags: superreview?(jonas)
Attachment #610416 -
Flags: review?(bugs)
Assignee | ||
Comment 7•12 years ago
|
||
Attachment #610337 -
Attachment is obsolete: true
Attachment #610337 -
Flags: superreview?(jonas)
Attachment #610418 -
Flags: superreview?(jonas)
Attachment #610418 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #610415 -
Flags: review?(bugs) → review+
Comment 8•12 years ago
|
||
Comment on attachment 610416 [details] [diff] [review] Part 2 - Basic security model >-nsScreen::Create(nsPIDOMWindow* aWindow) >+nsScreen::Create(nsGlobalWindow* aWindow) Is there now any need for this change? > { >+ if (!aWindow) { >+ return nsnull; >+ } MOZ_ASSERT that aWindow is not null >+ nsCOMPtr<nsIDOMWindow> window = do_QueryInterface(GetOwner()); GetOwner returns nsPIDOMWindow which is-a nsIDOMWindow, so there shouldn't be need for this QI ; > } > >+ > NS_IMETHODIMP Extra newline before NS_IMETHODIMP
Attachment #610416 -
Flags: review?(bugs) → review+
Comment 9•12 years ago
|
||
Comment on attachment 610418 [details] [diff] [review] Part 3 - Revert orientation when fullscreen is left >+ private: >+ nsIDOMEventTarget* mTarget; Just use event->GetCurrentTarget();
Attachment #610418 -
Flags: review?(bugs) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #610416 -
Flags: superreview?(jonas)
Assignee | ||
Updated•12 years ago
|
Attachment #610418 -
Flags: superreview?(jonas)
Attachment #610415 -
Flags: superreview?(jonas) → superreview+
Assignee | ||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a1ba687fd66a https://hg.mozilla.org/mozilla-central/rev/d8aa32fa5531 https://hg.mozilla.org/mozilla-central/rev/13bf530d772d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla14
Comment 11•11 years ago
|
||
This has been documented, some time ago ;-)
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•