The default bug view has changed. See this FAQ.

Screen Orientation API: implement locking

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({dev-doc-complete})

Trunk
mozilla14
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 610332 [details] [diff] [review]
Part 1 - HAL/DOM boilerplate

Basically, we want to add a lockOrientation(DOMString orientation) method to window.screen.
Attachment #610332 - Flags: superreview?(jonas)
Attachment #610332 - Flags: review?(bugs)
(Assignee)

Comment 1

5 years ago
Created attachment 610336 [details] [diff] [review]
Part 2 - Basic security model

Basically, regular content will have to be fullscreen and chrome can do whatever they want.
Attachment #610336 - Flags: superreview?(jonas)
Attachment #610336 - Flags: review?(bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 610337 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left
Attachment #610337 - Flags: superreview?(jonas)
Attachment #610337 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Depends on: 740190
(Assignee)

Updated

5 years ago
Whiteboard: [needs review]
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
Attachment #610332 - Flags: review?(bugs) → review-
Comment on attachment 610336 [details] [diff] [review]
Part 2 - Basic security model

Use GetOwner(), no mOwner
Attachment #610336 - Flags: review?(bugs) → review-
Comment on attachment 610337 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left

Please no raw pointers which you don't clear ever.
Attachment #610337 - Flags: review?(bugs) → review-
(Assignee)

Comment 5

5 years ago
Created attachment 610415 [details] [diff] [review]
Part 1 - HAL/DOM boilerplate
Attachment #610332 - Attachment is obsolete: true
Attachment #610332 - Flags: superreview?(jonas)
Attachment #610415 - Flags: superreview?(jonas)
Attachment #610415 - Flags: review?(bugs)
(Assignee)

Comment 6

5 years ago
Created attachment 610416 [details] [diff] [review]
Part 2 - Basic security model
Attachment #610336 - Attachment is obsolete: true
Attachment #610336 - Flags: superreview?(jonas)
Attachment #610416 - Flags: superreview?(jonas)
Attachment #610416 - Flags: review?(bugs)
(Assignee)

Comment 7

5 years ago
Created attachment 610418 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left
Attachment #610337 - Attachment is obsolete: true
Attachment #610337 - Flags: superreview?(jonas)
Attachment #610418 - Flags: superreview?(jonas)
Attachment #610418 - Flags: review?(bugs)
Attachment #610415 - Flags: review?(bugs) → review+
Comment on attachment 610416 [details] [diff] [review]
Part 2 - Basic security model


>-nsScreen::Create(nsPIDOMWindow* aWindow)
>+nsScreen::Create(nsGlobalWindow* aWindow)
Is there now any need for this change?



> {
>+  if (!aWindow) {
>+    return nsnull;
>+  }
MOZ_ASSERT that aWindow is not null


>+  nsCOMPtr<nsIDOMWindow> window = do_QueryInterface(GetOwner());
GetOwner returns nsPIDOMWindow which is-a nsIDOMWindow, so there shouldn't be
need for this QI
;
> }
> 
>+
> NS_IMETHODIMP
Extra newline before NS_IMETHODIMP
Attachment #610416 - Flags: review?(bugs) → review+
Comment on attachment 610418 [details] [diff] [review]
Part 3 - Revert orientation when fullscreen is left


>+  private:
>+    nsIDOMEventTarget* mTarget;

Just use event->GetCurrentTarget();
Attachment #610418 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Attachment #610416 - Flags: superreview?(jonas)
(Assignee)

Updated

5 years ago
Attachment #610418 - Flags: superreview?(jonas)
Attachment #610415 - Flags: superreview?(jonas) → superreview+
(Assignee)

Comment 10

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a1ba687fd66a
https://hg.mozilla.org/mozilla-central/rev/d8aa32fa5531
https://hg.mozilla.org/mozilla-central/rev/13bf530d772d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [needs review]
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Depends on: 743217
(Assignee)

Updated

5 years ago
Depends on: 747442
(Assignee)

Updated

5 years ago
Depends on: 764753
(Assignee)

Updated

5 years ago
Depends on: 766903
This has been documented, some time ago ;-)
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.