740256 - Password field empty for accounts created using browserID

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Admin tools-> Users
2. Pick an account created via browserID (https://addons-dev.allizom.org/en-US/admin/models/auth/user/6115955/)
3. Notice that Password field is empty
4. Add some privileges and hit save.



observed behavior:
Unable to make changes to the account since password field is empty.

Comment 1

[Kumar McMillan [:kumar]]

what is the use case here? what privileges are you trying to add?

Comment 2

[krupa raj[:krupa]]

(In reply to Kumar McMillan [:kumar] from comment #1)
> what is the use case here? what privileges are you trying to add?

You cannot make any changes to an account created using browserID which includes making them an editor/admin or granting them access to view stuff on our site. This will be a problem when we make browserID the only way to register in AMO/MP.

Comment 3

[Kumar McMillan [:kumar]]

does the reset password link from the admin pages work?

Comment 4

[Jason Smith [:jsmith]]

FYI - I'm blocked by this issue to access marketplace.mozilla.org, as I appear to have hit this corner case. Is there a work-around?

Comment 5

[krupa raj[:krupa]]

We should fix this problem asap as new editors are hitting this
 usecase on prod.

Comment 6

[Christopher Van Wiemeersch [:cvan]]

(In reply to krupa raj 82[:krupa] from comment #5)
> We should fix this problem asap as new editors are hitting this
>  usecase on prod.

What do you mean new editors are hitting this? What's happening?

Comment 7

[krupa raj[:krupa]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #6)
> (In reply to krupa raj 82[:krupa] from comment #5)
> > We should fix this problem asap as new editors are hitting this
> >  usecase on prod.
> 
> What do you mean new editors are hitting this? What's happening?

STR:
1. User creates a new account using browserID/persona
2. We gant them editor privileges so that they can review apps for us
3. User tries to log in to marketplace.


observed behavior:
They never clear the second authentication step since we don't store their password.

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/ce1b45d

Comment 9

[Christopher Van Wiemeersch [:cvan]]

If you someone has an account created with browserID and I try to give that person admin/reviewer access he/she will not be able to log in since we require a non-browserID password to authenticate. Grr...

Comment 10

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/7829435

You can reset/create your password using

https://addons.mozilla.org/en-US/firefox/users/pwreset
https://marketplace-dev.allizom.org/en-US/users/pwreset

Comment 11

[Christopher Van Wiemeersch [:cvan]]

Reopening since I reverted: https://github.com/mozilla/zamboni/commit/691f9b1

Comment 12

[Christopher Van Wiemeersch [:cvan]]

I ported https://addons.mozilla.org/en-US/firefox/users/pwreset to https://marketplace-dev.allizom.org/en-US/users/pwreset but it broke some things. Until I can more closely look at that, I'm bumping this.

If you forget your password, use https://addons.mozilla.org/en-US/firefox/users/pwreset for now.

Comment 13

[Christopher Van Wiemeersch [:cvan]]

This really isn't a big deal right now. Maybe I'll revisit it later.

Comment 14

[Andy McKay]

Migration took 79.13 seconds on -dev fwiw.

Comment 15

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/3b86471

Thanks, JR! Yeah that's a hefty migration.

Comment 16

[krupa raj[:krupa]]

The form cant be edited due to a traceback. But that's bug 785521

We got rid of the password field. Marking this verified