740544 - Show Java update information on plugincheck when there's no referrer

Status: RESOLVED FIXED

(Websites :: plugins.mozilla.org, defect)

Description

[Kev Needham [:kev]]

+++ This bug was initially created as a clone of Bug #633285 +++

We are planning to do some widespread blocking of older Java versions in bug 739955. We will probably have a number of ways for a user to end up at the plugincheck page after Java is blocked.

The problem is that because the Java Plugin is blocked, plugincheck won't be able to detect the outdated version and therefore can't offer an update path to the end user.

We'd like to display some information about the Java plugin in cases where:
1. there is no referrer to the page (this probably means they clicked on a blocklist infobar to get there)
2. there is a parameter, something like ?java=1

This bug is pretty much identical to the work performed for bug 633285, with the main difference being that we'll be blocking the Java plugin, not Flash.

Fligtar, can you conform this is the best case for this, and not a custom landing/update page we direct users to that is block-specific? Note that plugincheck is localized, and we'd also need help from the l10n teams.

Comment 1

[Laura Thomson :laura]

rhelmer is working up a patch, if those that have worked on it before can review, jlongster will land it on trunk.

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: proposed fix

Here's a quick, untested patch so we can talk about it.

I have a few questions:

1) do we care about showing the blocklist info for both flash and java? right now it's either/or
2) related to #1, if !document.referrer and java=1 and flash=1 are missing from href, this patch is going to show java. Is that ok?
3) should we link to a place to upgrade java? I just stuck in http://java.com/inc/BrowserRedirect1.jsp for now

Comment 3

[Justin Scott [:fligtar]]

(In reply to Kev [:kev] Needham from comment #0)
> Fligtar, can you conform this is the best case for this, and not a custom
> landing/update page we direct users to that is block-specific? Note that
> plugincheck is localized, and we'd also need help from the l10n teams.

We can't change where the "Update Plugins..." link goes to in the infobar, so unfortunately we're stuck with landing on plugincheck.

Comment 4

[Robert Helmer [:rhelmer]]

Attachment: replace flash blocklist alert with java

Actually, fligtar says in #webdev that we never used the flash blocklist alert from bug 633285, so perhaps we should just simplify and just s/flash/java/ ?

If that's ok, points from comment 2 are moot except for if we should link to Java download and if so what the URL should be.

Comment 5

[Fred Wenzel [:wenzel]]

Comment on attachment 610680 [details] [diff] [review]
replace flash blocklist alert with java

I did not run this, but this looks reasonable.

Who can answer the question if we should *replace* the existing Flash warning? If it should show up in addition to it, you'll need to change this. Also, then you'll need to decide which one to go for without a referrer (I suggest, Java, or both).

Comment 6

[Robert Helmer [:rhelmer]]

(In reply to Fred Wenzel [:wenzel] from comment #5)
> Comment on attachment 610680 [details] [diff] [review]
> replace flash blocklist alert with java
> 
> I did not run this, but this looks reasonable.
> 
> Who can answer the question if we should *replace* the existing Flash
> warning? If it should show up in addition to it, you'll need to change this.
> Also, then you'll need to decide which one to go for without a referrer (I
> suggest, Java, or both).

kev and fligtar both say we can replace the existing warning since it was never used.

Comment 7

[Fred Wenzel [:wenzel]]

Landed on trunk in r103606. This should show up on www-dev.allizom shortly.

Comment 8

[raymond [:retornam] (inactive)]

Attachment: screenshot

The dialog is shown when I don't have java installed.

Comment 9

[Robert Helmer [:rhelmer]]

Deployed to http://www.mozilla.org/en-US/plugincheck/

Thanks everybody!