74055 - crash when using the subscribe dialog on servers with non-ASCII newsgroups

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect, P1)

Description

[zz_sz]

every time when I subcribe from news.webking.com.cn,it appears a error!you can 
try it for a test.

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

What build ID? Is this a public news server, or does it run on a private ISP's 
server?  What is the error message that you receive?  Please read 
http://www.mozilla.org/quality/bug-writing-guidelines.html in the future when 
writing bugs.  Thanks for reporting bugs in Mozilla.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

I'll attach a log of my tracert to your news server.  Looks like the news server
is on a bad network segment (but I'd have to tracert it over time to find out
for sure.)  Could it be the server is having it's own problems, or that you are
just having network issues in general?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Attachment: tracert to the server.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Forget that.  This bug is confirmed, sorry.  I was thinking this would be a 
private server, and I wouldn't even be able to get that far.  Stack coming.

Comment 5

[[e-mail] (gone - use [e-mail] instead)]

Seth, it's an international group, with newsgroup named similar to ±¾Íø¹«¸æ 
(it's publically accessible, my bad) Works in 4.x.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Attachment: TB28572916

Comment 7

[(not reading, please use [e-mail] instead)]

crasher -> 0.9

accepting.

Comment 8

[(not reading, please use [e-mail] instead)]

working on this now.

Comment 9

[(not reading, please use [e-mail] instead)]

*** Bug 75350 has been marked as a duplicate of this bug. ***

Comment 10

[(not reading, please use [e-mail] instead)]

back to working on this, a little more involved that I thought.

Comment 11

[scottputterman]

moving to mozilla0.9.1

Comment 12

[(not reading, please use [e-mail] instead)]

update, to support non ASCII newsgroup names I have to add escaping and 
unescaping in various places.

the reason for that is the newsgroup name shows up in our RDF uris, and it must 
be escaped UTF8.

basically, on disk (newsrc or hostinfo.dat) or on the wire (when being sent to 
the newsrc server), I'm using the unescaped latin-1 encoded version (like 4.x 
did) and then internal I'm using escaped UTF8.

it has no effect on normal ASCII newsgroups, except for strings copies and 
wasted time escaping / unescaping.

I'll land it in 0.9.1.

Comment 13

[(not reading, please use [e-mail] instead)]

updating summary.  still working on a clean and complete patch for this.

Comment 14

[(not reading, please use [e-mail] instead)]

the other half of this problem is if you were subscribed to non-ASCII 
newsgroups in 4.x and you migrated.  

I'm *still* working on this fix.

it's not fun.

Comment 15

[(not reading, please use [e-mail] instead)]

fix in hand, just cleaning it up now.

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: first draft of the fix. uri are encoded as escaped UTF-8, but in the UI, on disk (news.rc and hostinfo.dat) and over the wire they are in latin-1 (ISO-8859-1)

Comment 17

[(not reading, please use [e-mail] instead)]

revised patch coming soon, which moves the common code into nsMsgUtils.cpp

adding cavin, he's going to need the util functions for a bug he's working on.

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: the fix (includes util functions)

Comment 19

[(not reading, please use [e-mail] instead)]

so on disk (newsrc, hostinfo.dat) and on the wire we use the ISO-8859-1 version 
of the name.  (just like 4.x did, so migration works)

internally, and in our URIs, we use the escaped UTF-8 version.

there's also some cleanup of printfs mixed in there too.

Comment 20

[Scott MacGregor]

sr=mscott

Comment 21

[David :Bienvenu]

r=bienenu

Comment 22

[(not reading, please use [e-mail] instead)]

fixed.

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

Amen!  I can subscribe to newsgroups (non-ascii) on news://news.webking.com.cn,
with builds:

Mac OS 9.1 2001-05-11-09
Windows 2000 2001-05-11-04
Linux RedHat 7.0 2001-05-11-08

Booya!