740807 - Clean up favicon code in Panorama

Status: RESOLVED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v1

In the last weeks the favicon handling code in Panorama grew a lot and it really started to get messy. In fact, there's so much code now that I think it deserves its own file and should no longer remain in the "UI" object.

This depends on bug 728142 as I don't want to let this bitrot just because of some clean up.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 610881 [details] [diff] [review]
patch v1

Review of attachment 610881 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/tabview/favicons.js
@@ +31,5 @@
> +    Services.prefs.addObserver(this.PREF_CHROME_FAVICONS, this, false);
> +  },
> +
> +  uninit: function FavIcons_uninit() {
> +    this._favIconService = null;

I'll remove this line as we can't simply overwrite a getter and we don't need it anyway.

Comment 2

[Raymond Lee [:raymondlee]]

Comment on attachment 610881 [details] [diff] [review]
patch v1

Looks good to me!

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: patch v2

All blocking bugs are fixed. Review time!

Comment 4

[Dietrich Ayala (:dietrich)]

Comment on attachment 614731 [details] [diff] [review]
patch v2

Review of attachment 614731 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/ae940000a826

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/ae940000a826