The default bug view has changed. See this FAQ.

Clean up favicon code in Panorama

RESOLVED FIXED in Firefox 14

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

Trunk
Firefox 14

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 610881 [details] [diff] [review]
patch v1

In the last weeks the favicon handling code in Panorama grew a lot and it really started to get messy. In fact, there's so much code now that I think it deserves its own file and should no longer remain in the "UI" object.

This depends on bug 728142 as I don't want to let this bitrot just because of some clean up.
Attachment #610881 - Flags: feedback?(raymond)
(Assignee)

Comment 1

5 years ago
Comment on attachment 610881 [details] [diff] [review]
patch v1

Review of attachment 610881 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/tabview/favicons.js
@@ +31,5 @@
> +    Services.prefs.addObserver(this.PREF_CHROME_FAVICONS, this, false);
> +  },
> +
> +  uninit: function FavIcons_uninit() {
> +    this._favIconService = null;

I'll remove this line as we can't simply overwrite a getter and we don't need it anyway.
Comment on attachment 610881 [details] [diff] [review]
patch v1

Looks good to me!
Attachment #610881 - Flags: feedback?(raymond) → feedback+
(Assignee)

Comment 3

5 years ago
Created attachment 614731 [details] [diff] [review]
patch v2

All blocking bugs are fixed. Review time!
Attachment #610881 - Attachment is obsolete: true
Attachment #614731 - Flags: review?(dietrich)
Comment on attachment 614731 [details] [diff] [review]
patch v2

Review of attachment 614731 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, r=me
Attachment #614731 - Flags: review?(dietrich) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/ae940000a826
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/ae940000a826
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.