740854 - Remove SYSTEM_MAKEDEPEND and MOZ_NATIVE_MAKEDEPEND and associated crap

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

All of our officially-supported platforms don't use mkdepend at all (GCC, VC++, probably clang). Even if we were going to use mkdepend, we have an in-tree copy, so it doesn't seem worth carrying around the baggage to handle system mkdepend for those few cases where someone might want to use it. catlee hit a build error related to this because he didn't have a system mkdepend installed, apparently.

Comment 1

[Chris AtLee [:catlee]]

the specific error was in 'make maybe_cleanup_profiledbuild' and make would forkbomb itself trying to cleanup objdir/config/mkdepend early in the 2nd pass of a PGO build

installing a system 'makedepend' has fixed this for me.

Comment 2

[Mike Hommey [:glandium]]

While at it, we can probably get rid of makedep.

Comment 3

[Rain [:rain1] (inactive)]

Attachment: remove all the things

I've removed all references to
- COMPILER_DEPEND
- MOZ_NATIVE_MAKEDEPEND
- SYSTEM_MAKEDEPEND
- MKDEPEND

except those that are part of NSS.

I've pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=9112e63ad6b3

Comment 4

[Rain [:rain1] (inactive)]

Attachment: fixed patch

Fixed a mistake in js/src/configure.in.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2f2f763a437d

Comment 5

[Rain [:rain1] (inactive)]

Attachment: remove MOZ_AUTO_DEPS as well

Ted was of the opinion that MOZ_AUTO_DEPS should go as well.

This needs bug 782759.

Comment 6

[Rain [:rain1] (inactive)]

My try push (builds only, on all platforms) was all green.

Comment 7

[Rain [:rain1] (inactive)]

Attachment: updated for bitrot

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 653960 [details] [diff] [review]
updated for bitrot

Review of attachment 653960 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7686,1 @@
>  AC_SUBST(MDDEPDIR)

We could probably just move MDDEPDIR to config.mk.

::: js/src/config/Makefile.in
@@ +62,5 @@
>  endif
>  
>  GARBAGE += $(srcdir)/*.pyc *.pyc
>  
>  FORCE:

What is this nonsense doing here? Don't we have FORCE listed as PHONY somewhere?

Comment 9

[Rain [:rain1] (inactive)]

(In reply to Ted Mielczarek [:ted] from comment #8)
> 
> ::: js/src/config/Makefile.in
> @@ +62,5 @@
> >  endif
> >  
> >  GARBAGE += $(srcdir)/*.pyc *.pyc
> >  
> >  FORCE:
> 
> What is this nonsense doing here? Don't we have FORCE listed as PHONY
> somewhere?

Indeed. Filed bug 786002.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8ac55d26cf22