Closed Bug 740854 Opened 8 years ago Closed 8 years ago

Remove SYSTEM_MAKEDEPEND and MOZ_NATIVE_MAKEDEPEND and associated crap

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla18

People

(Reporter: ted, Assigned: rain1)

References

Details

Attachments

(1 file, 3 obsolete files)

All of our officially-supported platforms don't use mkdepend at all (GCC, VC++, probably clang). Even if we were going to use mkdepend, we have an in-tree copy, so it doesn't seem worth carrying around the baggage to handle system mkdepend for those few cases where someone might want to use it. catlee hit a build error related to this because he didn't have a system mkdepend installed, apparently.
the specific error was in 'make maybe_cleanup_profiledbuild' and make would forkbomb itself trying to cleanup objdir/config/mkdepend early in the 2nd pass of a PGO build

installing a system 'makedepend' has fixed this for me.
While at it, we can probably get rid of makedep.
Blocks: 717947
Blocks: 593585
Attached patch remove all the things (obsolete) — Splinter Review
I've removed all references to
- COMPILER_DEPEND
- MOZ_NATIVE_MAKEDEPEND
- SYSTEM_MAKEDEPEND
- MKDEPEND

except those that are part of NSS.

I've pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=9112e63ad6b3
Assignee: nobody → sagarwal
Status: NEW → ASSIGNED
Attachment #651854 - Flags: review?(ted.mielczarek)
Attached patch fixed patch (obsolete) — Splinter Review
Fixed a mistake in js/src/configure.in.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2f2f763a437d
Attachment #651854 - Attachment is obsolete: true
Attachment #651854 - Flags: review?(ted.mielczarek)
Attachment #651856 - Flags: review?(ted.mielczarek)
Depends on: 782759
No longer blocks: 593585
Attached patch remove MOZ_AUTO_DEPS as well (obsolete) — Splinter Review
Ted was of the opinion that MOZ_AUTO_DEPS should go as well.

This needs bug 782759.
Attachment #651856 - Attachment is obsolete: true
Attachment #651856 - Flags: review?(ted.mielczarek)
Attachment #651865 - Flags: review?(ted.mielczarek)
My try push (builds only, on all platforms) was all green.
Attachment #651865 - Attachment is obsolete: true
Attachment #651865 - Flags: review?(ted.mielczarek)
Attachment #653960 - Flags: review?(ted.mielczarek)
Comment on attachment 653960 [details] [diff] [review]
updated for bitrot

Review of attachment 653960 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +7686,1 @@
>  AC_SUBST(MDDEPDIR)

We could probably just move MDDEPDIR to config.mk.

::: js/src/config/Makefile.in
@@ +62,5 @@
>  endif
>  
>  GARBAGE += $(srcdir)/*.pyc *.pyc
>  
>  FORCE:

What is this nonsense doing here? Don't we have FORCE listed as PHONY somewhere?
Attachment #653960 - Flags: review?(ted.mielczarek) → review+
Depends on: 785336
(In reply to Ted Mielczarek [:ted] from comment #8)
> 
> ::: js/src/config/Makefile.in
> @@ +62,5 @@
> >  endif
> >  
> >  GARBAGE += $(srcdir)/*.pyc *.pyc
> >  
> >  FORCE:
> 
> What is this nonsense doing here? Don't we have FORCE listed as PHONY
> somewhere?

Indeed. Filed bug 786002.
https://hg.mozilla.org/mozilla-central/rev/8ac55d26cf22
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
Blocks: 806616
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.