Comment 1 Daniel Holbert [:dholbert] 2012-03-30 13:29:19 PDT

Created attachment 610993 [details] [diff] [review]
fix

I'm doing a clobber build before requesting review, to be absolutely sure this is dead code.

Comment 2 Robert Longson 2012-03-30 13:31:06 PDT

The patch I submitted was supposed to rename this file...

> diff --git a/layout/svg/base/src/nsSVGLeafFrame.cpp b/layout/svg/base/src/SVGFELeafFrame.cpp
> copy from layout/svg/base/src/nsSVGLeafFrame.cpp
> copy to layout/svg/base/src/SVGFELeafFrame.cpp

Comment 3 Daniel Holbert [:dholbert] 2012-03-30 13:34:08 PDT

Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg mv" -- makes sense.

Thanks for the quick r+! :)

Comment 4 Daniel Holbert [:dholbert] 2012-03-30 13:38:55 PDT

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2d6134783b

Comment 5 Robert Longson 2012-03-30 13:48:24 PDT

(In reply to Daniel Holbert [:dholbert] from comment #3)
> Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg
> mv" -- makes sense.
> 
> Thanks for the quick r+! :)

I didn't land it  :-)

Comment 6 Robert Longson 2012-03-30 13:53:05 PDT

All's well that ends well. I meant to do a move, shouldn't that have counted ;-)

Comment 7 Daniel Holbert [:dholbert] 2012-03-30 14:23:33 PDT

(In reply to Robert Longson from comment #5)
> I didn't land it  :-)

(right -- but the "copy from" in the posted changeset patch indicates that it was a "hg cp".  If it had been a move, it would have said "rename from" instead of "copy from".)

In any case - very minor issue, & indeed all's well that ends well. :)

Comment 8 Ed Morley [:emorley] 2012-03-31 19:29:34 PDT

https://hg.mozilla.org/mozilla-central/rev/ec2d6134783b