|
3.94 KB,
patch
|
Robert Longson
:
review+
|
Details | Diff | Splinter Review |
Bug 696078 removed the Makefile-line for nsSVGLeafFrame.cpp and removed all uses of it, but the .cpp file itself remains. Filing this bug on removing it, since it's dead code now.
|
(Assignee) | |
Comment 1•5 years ago
|
||
Created attachment 610993 [details] [diff] [review] fix I'm doing a clobber build before requesting review, to be absolutely sure this is dead code.
|
||
Comment 2•5 years ago
|
||
The patch I submitted was supposed to rename this file...
> diff --git a/layout/svg/base/src/nsSVGLeafFrame.cpp b/layout/svg/base/src/SVGFELeafFrame.cpp
> copy from layout/svg/base/src/nsSVGLeafFrame.cpp
> copy to layout/svg/base/src/SVGFELeafFrame.cpp|
|
||
Updated•5 years ago
|
||
|
|
(Assignee) | |
Comment 3•5 years ago
|
||
Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg mv" -- makes sense. Thanks for the quick r+! :)
|
|
(Assignee) | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec2d6134783b
|
|
||
Comment 5•5 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #3) > Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg > mv" -- makes sense. > > Thanks for the quick r+! :) I didn't land it :-)
|
|
||
Comment 6•5 years ago
|
||
All's well that ends well. I meant to do a move, shouldn't that have counted ;-)
|
|
(Assignee) | |
Comment 7•5 years ago
|
||
(In reply to Robert Longson from comment #5) > I didn't land it :-) (right -- but the "copy from" in the posted changeset patch indicates that it was a "hg cp". If it had been a move, it would have said "rename from" instead of "copy from".) In any case - very minor issue, & indeed all's well that ends well. :)
|
||
Comment 8•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ec2d6134783b
Description
•