Closed Bug 740945 Opened 8 years ago Closed 8 years ago

remove unused and un-built nsSVGLeafFrame

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Bug 696078 removed the Makefile-line for nsSVGLeafFrame.cpp and removed all uses of it, but the .cpp file itself remains.

Filing this bug on removing it, since it's dead code now.
Attached patch fixSplinter Review
I'm doing a clobber build before requesting review, to be absolutely sure this is dead code.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
The patch I submitted was supposed to rename this file...

> diff --git a/layout/svg/base/src/nsSVGLeafFrame.cpp b/layout/svg/base/src/SVGFELeafFrame.cpp
> copy from layout/svg/base/src/nsSVGLeafFrame.cpp
> copy to layout/svg/base/src/SVGFELeafFrame.cpp
Attachment #610993 - Flags: review+
Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg mv" -- makes sense.

Thanks for the quick r+! :)
(In reply to Daniel Holbert [:dholbert] from comment #3)
> Ah -- so it looks like you must've accidentally done "hg cp" instead of "hg
> mv" -- makes sense.
> 
> Thanks for the quick r+! :)

I didn't land it  :-)
All's well that ends well. I meant to do a move, shouldn't that have counted ;-)
(In reply to Robert Longson from comment #5)
> I didn't land it  :-)

(right -- but the "copy from" in the posted changeset patch indicates that it was a "hg cp".  If it had been a move, it would have said "rename from" instead of "copy from".)

In any case - very minor issue, & indeed all's well that ends well. :)
https://hg.mozilla.org/mozilla-central/rev/ec2d6134783b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.