Closed
Bug 740974
Opened 12 years ago
Closed 12 years ago
toolbar currentSet setter needs to return 'val' when returning early
Categories
(Toolkit :: Toolbars and Toolbar Customization, defect)
Toolkit
Toolbars and Toolbar Customization
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: dao, Assigned: vingtetun)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
799 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
||
Comment 1•12 years ago
|
||
Does this actually matter in practice? IIRC the return value of XBL setters is actually ignored.
|
||
Comment 2•12 years ago
|
||
Well, something needs to be done to fix the JS strict warning at least...
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → 21
Attachment #612586 -
Flags: review?(dao)
|
Reporter | |
Comment 4•12 years ago
|
||
Comment on attachment 612586 [details] [diff] [review] Patch thanks!
Attachment #612586 -
Flags: review?(dao) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/569698a19cb7
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
|
||
Comment 6•12 years ago
|
||
Sorry, this push was backed out on inbound because one of the changesets caused a leak: https://hg.mozilla.org/integration/mozilla-inbound/rev/92cc2053db2f
Target Milestone: mozilla14 → ---
|
|
Assignee | |
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe5ba1320d47
Target Milestone: --- → mozilla14
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fe5ba1320d47
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•