The default bug view has changed. See this FAQ.

Location / search bar splitter moves to the end of the toolbar when toggling "tabs on top"

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Toolbars and Customization
--
minor
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Theodore, Assigned: dao)

Tracking

({polish, regression})

Trunk
Firefox 14
x86
Windows 7
polish, regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking2.0 .x+)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

7 years ago
User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre
Build Identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100810 Minefield/4.0b4pre

The search field/location bar cannot be resized if you set tabs to be on bottom.

Reproducible: Always

Steps to Reproduce:
1. When tabs are on top, hover mouse over the divider between the location bar and search field, notice that arrows appear and the bar is resizable.
2. Right-click toolbar and uncheck "Tabs on Top" option.
3. Hover mouse over location bar/search field divider again, notice that no arrows appear and the bar is not resizable. 
Actual Results:  
Location bar/search field is not resizable.

Expected Results:  
Should be able to resize search field.

I tested this with Aero enabled. If you switch the tabs back on top, the bar is still not resizable. It only becomes resizable again if you restart the browser or right-click toolbar, choose customize, and click "Restore Default Set".

Comment 1

7 years ago
I can confirm in Aero style.
The problem does not happen in non-Aero style.

After having carried out "Customize toolbar > Done", the rersizer works again.


Regression window:
Works:
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624095420
Fails:
http://hg.mozilla.org/mozilla-central/rev/cc7c030f6b42
Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100623 Minefield/3.7a6pre ID:20100624112154
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4a6f3d15cfdc&tochange=cc7c030f6b42
Candidate Bug:
Bug 555081 - Can't move the window using the titlebar with custom titlebar drawing or glass areas below the titlebar
Blocks: 555081
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 586158
Seems to be Win7 only, right?
blocking2.0: --- → ?
Version: unspecified → Trunk

Updated

7 years ago
Keywords: regression
Duplicate of this bug: 589451
blocking2.0: ? → final+
Likely not a widget bug. This code fails to update correctly for some reason:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#2366

Maybe this is something similar to bug 555987 [{inc}Dynamically changing -moz-box-ordinal-group doesn't work].

Comment 6

7 years ago
Changing tab position causes re-binding.

  /* Make the window draggable by glassed toolbars (bug 555081) */
    ...
    #navigator-toolbox[tabsontop="false"] > #nav-bar,
    ... {
>>    -moz-binding: url("chrome://global/content/bindings/toolbar.xml#toolbar-drag");
    }

However, the binding constructor does not call UpdateUrlbarSearchSplitterState.
So this problem happens.
(Assignee)

Updated

7 years ago
Summary: When tabs are placed on bottom, search field cannot be resized → When toggling "tabs on top", search field cannot be resized
(Assignee)

Updated

7 years ago
Assignee: nobody → dao
(Assignee)

Comment 7

7 years ago
Created attachment 489799 [details] [diff] [review]
patch
Attachment #489799 - Flags: review?(mano)
No, johnathan, this doesn't block.
blocking2.0: final+ → .x
Keywords: polish

Updated

6 years ago
Duplicate of this bug: 624113
(Assignee)

Comment 10

6 years ago
Created attachment 513891 [details] [diff] [review]
better patch
Attachment #489799 - Attachment is obsolete: true
Attachment #513891 - Flags: review?(enndeakin)
Attachment #489799 - Flags: review?(mano)
(In reply to comment #10)
> Created attachment 513891 [details] [diff] [review]
> better patch

I find that with this new patch, in order to get the splitter to function, I have to enter/exit "Toolbar Layout" after toggling tabs-on-top.

This is with Windows 7.

Comment 12

6 years ago
Can you explain when someone would use this 'skipintoolbarset' attribute?

Also, tests should be added to test_toolbar.xul
(Assignee)

Comment 13

6 years ago
(In reply to comment #12)
> Can you explain when someone would use this 'skipintoolbarset' attribute?

When adding nodes to the toolbar that aren't supposed to participate in toolbar customization, like the splitter. The (val == this.currentSet) check wouldn't work otherwise. this.currentSet would contain urlbar-search-splitter but val wouldn't.
(Assignee)

Updated

6 years ago
Summary: When toggling "tabs on top", search field cannot be resized → Location / search bar splitter moves to the end of the toolbar when toggling "tabs on top"
(Assignee)

Comment 14

6 years ago
Created attachment 514472 [details] [diff] [review]
test added
Attachment #513891 - Attachment is obsolete: true
Attachment #514472 - Flags: review?(enndeakin)
Attachment #513891 - Flags: review?(enndeakin)

Updated

6 years ago
Duplicate of this bug: 642115
Just FYI, I see this almost every day.  When I was looking into this in August (to see if it was something I was causing) I added a little CSS in Stylish to make #urlbar-search-splitter's position obvious:

#urlbar-search-splitter { background-color: lime !important; }

and I never turned that off. So, like I said, with my usage pattern, I still notice this on the order of once a day.  FWIW.
(Assignee)

Comment 17

5 years ago
Created attachment 607966 [details] [diff] [review]
patch

updated to tip
Attachment #514472 - Attachment is obsolete: true
Attachment #607966 - Flags: review?(neil)
Attachment #514472 - Flags: review?(enndeakin)

Updated

5 years ago
Attachment #607966 - Flags: review?(neil) → review+
(Assignee)

Comment 18

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/fe40e7c2d790
Flags: in-testsuite+
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/fe40e7c2d790
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Comment on attachment 607966 [details] [diff] [review]
patch

Bah, I knew I had forgotten somthing...

>+            if (val == this.currentSet)
>+              return;
This should return val.
(Assignee)

Updated

5 years ago
Depends on: 740974
You need to log in before you can comment on or make changes to this bug.