Closed
Bug 741064
Opened 12 years ago
Closed 12 years ago
treeView.js: "function PTV__buildVisibleSection does not always return a value"
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 14
People
(Reporter: sgautherie, Assigned: sgautherie)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
{
265 return;
276 return cc;
319 return rowsInserted;
}
Should it return null?
|
Assignee | |
Updated•12 years ago
|
Summary: "function PTV__buildVisibleSection does not always return a value" → treeView.js: "function PTV__buildVisibleSection does not always return a value"
|
||
Comment 1•12 years ago
|
||
Looking at the callers, it would be better to return 0.
|
|
Assignee | |
Comment 2•12 years ago
|
||
(In reply to Bill Gianopoulos [:WG9s] from comment #1) > it would be better to return 0. Right.
|
||
Updated•12 years ago
|
Attachment #611153 -
Flags: review?(mano) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 611153 [details] [diff] [review] (Av1) Fix "function PTV__buildVisibleSection does not always return a value" [Checked in: Comment 3] https://hg.mozilla.org/mozilla-central/rev/dd21f16d11da
Attachment #611153 -
Attachment description: (Av1) Fix "function PTV__buildVisibleSection does not always return a value" → (Av1) Fix "function PTV__buildVisibleSection does not always return a value"
[Checked in: Comment 3]
|
|
Assignee | |
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-firefox11:
--- → wontfix
status-firefox12:
--- → wontfix
status-firefox13:
--- → wontfix
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
|
|
Assignee | |
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=10547706&tree=Firefox&full=1 Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 04:17:41 PDT for push 8b75b4f686e7 { JavaScript strict warning: chrome://browser/content/places/treeView.js, line 276: function PTV__buildVisibleSection does not always return a value JavaScript strict warning: chrome://browser/content/places/treeView.js, line 319: function PTV__buildVisibleSection does not always return a value } https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1 Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da V.Fixed
Status: RESOLVED → VERIFIED
|
|
Assignee | |
Updated•12 years ago
|
status-firefox-esr10:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•