treeView.js: "function PTV__buildVisibleSection does not always return a value"

VERIFIED FIXED in Firefox 14

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
Firefox 14
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox11 wontfix, firefox12 wontfix, firefox13 wontfix, firefox-esr10 wontfix)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
{
265       return;
276       return cc;
319     return rowsInserted;
}

Should it return null?
(Assignee)

Updated

6 years ago
Summary: "function PTV__buildVisibleSection does not always return a value" → treeView.js: "function PTV__buildVisibleSection does not always return a value"
Looking at the callers, it would be better to return 0.
(Assignee)

Comment 2

6 years ago
Created attachment 611153 [details] [diff] [review]
(Av1) Fix "function PTV__buildVisibleSection does not always return a value"
[Checked in: Comment 3]

(In reply to Bill Gianopoulos [:WG9s] from comment #1)
> it would be better to return 0.

Right.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #611153 - Flags: review?(mano)
Attachment #611153 - Flags: review?(mano) → review+
(Assignee)

Comment 3

6 years ago
Comment on attachment 611153 [details] [diff] [review]
(Av1) Fix "function PTV__buildVisibleSection does not always return a value"
[Checked in: Comment 3]

https://hg.mozilla.org/mozilla-central/rev/dd21f16d11da
Attachment #611153 - Attachment description: (Av1) Fix "function PTV__buildVisibleSection does not always return a value" → (Av1) Fix "function PTV__buildVisibleSection does not always return a value" [Checked in: Comment 3]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox11: --- → wontfix
status-firefox12: --- → wontfix
status-firefox13: --- → wontfix
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Comment 4

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10547706&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 04:17:41 PDT for push 8b75b4f686e7
{
JavaScript strict warning: chrome://browser/content/places/treeView.js, line 276: function PTV__buildVisibleSection does not always return a value
JavaScript strict warning: chrome://browser/content/places/treeView.js, line 319: function PTV__buildVisibleSection does not always return a value
}


https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da

V.Fixed
Status: RESOLVED → VERIFIED
(Assignee)

Updated

5 years ago
status-firefox-esr10: --- → wontfix
You need to log in before you can comment on or make changes to this bug.