controller.js: "function PCDH_onDrop does not always return a value"

VERIFIED FIXED in Firefox 14

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
Firefox 14
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox11 wontfix, firefox12 wontfix, firefox13 wontfix, firefox-esr10 wontfix)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
{
1505       if (!flavor)
1506         return false;
}

Should it not return false? Or does it miss to return true at its end?
(Assignee)

Comment 1

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da
{
JavaScript strict warning: chrome://browser/content/places/controller.js, line 1509: function PCDH_onDrop does not always return a value
}
considered we never use its return value, should just return;
(Assignee)

Comment 3

5 years ago
Created attachment 611471 [details] [diff] [review]
(Av1) controller.js: Fix "function PCDH_onDrop does not always return a value"
[Checked in: Comment 4]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #611471 - Flags: review?(mak77)

Updated

5 years ago
Attachment #611471 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

5 years ago
Comment on attachment 611471 [details] [diff] [review]
(Av1) controller.js: Fix "function PCDH_onDrop does not always return a value"
[Checked in: Comment 4]

https://hg.mozilla.org/mozilla-central/rev/f9c4e2016539
Attachment #611471 - Attachment description: (Av1) controller.js: Fix "function PCDH_onDrop does not always return a value" → (Av1) controller.js: Fix "function PCDH_onDrop does not always return a value" [Checked in: Comment 4]
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox-esr10: --- → wontfix
status-firefox11: --- → wontfix
status-firefox12: --- → wontfix
status-firefox13: --- → wontfix
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Comment 5

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10599229&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitests-5/5 on 2012-04-03 07:16:33 PDT for push 5128e92c536c

V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.