Closed Bug 741065 Opened 9 years ago Closed 9 years ago

controller.js: "function PCDH_onDrop does not always return a value"

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 14
Tracking Status
firefox11 --- wontfix
firefox12 --- wontfix
firefox13 --- wontfix
firefox-esr10 --- wontfix

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

(Keywords: regression)

Attachments

(1 file)

{
1505       if (!flavor)
1506         return false;
}

Should it not return false? Or does it miss to return true at its end?
https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da
{
JavaScript strict warning: chrome://browser/content/places/controller.js, line 1509: function PCDH_onDrop does not always return a value
}
considered we never use its return value, should just return;
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #611471 - Flags: review?(mak77)
Attachment #611471 - Flags: review?(mak77) → review+
Comment on attachment 611471 [details] [diff] [review]
(Av1) controller.js: Fix "function PCDH_onDrop does not always return a value"
[Checked in: Comment 4]

https://hg.mozilla.org/mozilla-central/rev/f9c4e2016539
Attachment #611471 - Attachment description: (Av1) controller.js: Fix "function PCDH_onDrop does not always return a value" → (Av1) controller.js: Fix "function PCDH_onDrop does not always return a value" [Checked in: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
https://tbpl.mozilla.org/php/getParsedLog.php?id=10599229&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitests-5/5 on 2012-04-03 07:16:33 PDT for push 5128e92c536c

V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.