browserPlacesViews.js: 2 "function ... does not always return a value"

VERIFIED FIXED in Firefox 14

Status

()

Firefox
Bookmarks & History
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

({regression})

Trunk
Firefox 14
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox11 wontfix, firefox12 wontfix, firefox13 wontfix, firefox-esr10 wontfix)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/browserPlacesViews.js#52
{
57       return;
80     return val;
}
Should it always return val?


http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/browserPlacesViews.js#1669
{
1674       return;
1681     return PlacesViewBase.prototype._onPopupShowing.apply(this, arguments);
}
Should it always return no value?
(Assignee)

Comment 1

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da
{
JavaScript strict warning: chrome://browser/content/places/browserPlacesViews.js, line 80: anonymous function does not always return a value

JavaScript strict warning: chrome://browser/content/places/browserPlacesViews.js, line 1668: function PT__onPopupShowing does not always return a value
}
the former is a setter, it should always return val.
the latter should not return, just invoke the base method.
(Assignee)

Comment 3

6 years ago
Created attachment 611478 [details] [diff] [review]
(Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value"
[Checked in: Comment 4]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #611478 - Flags: review?(mak77)

Updated

6 years ago
Attachment #611478 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 611478 [details] [diff] [review]
(Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value"
[Checked in: Comment 4]

https://hg.mozilla.org/mozilla-central/rev/5128e92c536c
Attachment #611478 - Attachment description: (Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value" → (Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value" [Checked in: Comment 4]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
status-firefox-esr10: --- → wontfix
status-firefox11: --- → wontfix
status-firefox12: --- → wontfix
status-firefox13: --- → wontfix
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
(Assignee)

Comment 5

6 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10599229&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitests-5/5 on 2012-04-03 07:16:33 PDT for push 5128e92c536c

V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.