Closed
Bug 741066
Opened 13 years ago
Closed 13 years ago
browserPlacesViews.js: 2 "function ... does not always return a value"
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 14
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
(Keywords: regression)
Attachments
(1 file)
http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/browserPlacesViews.js#52
{
57 return;
80 return val;
}
Should it always return val?
http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/places/content/browserPlacesViews.js#1669
{
1674 return;
1681 return PlacesViewBase.prototype._onPopupShowing.apply(this, arguments);
}
Should it always return no value?
|
Assignee | |
Comment 1•13 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=10551807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitests-3/5 on 2012-04-01 09:57:28 PDT for push dd21f16d11da
{
JavaScript strict warning: chrome://browser/content/places/browserPlacesViews.js, line 80: anonymous function does not always return a value
JavaScript strict warning: chrome://browser/content/places/browserPlacesViews.js, line 1668: function PT__onPopupShowing does not always return a value
}
|
||
Comment 2•13 years ago
|
||
the former is a setter, it should always return val.
the latter should not return, just invoke the base method.
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Attachment #611478 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 611478 [details] [diff] [review]
(Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value"
[Checked in: Comment 4]
https://hg.mozilla.org/mozilla-central/rev/5128e92c536c
Attachment #611478 -
Attachment description: (Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value" → (Av1) browserPlacesViews.js: Fix 2 "function ... does not always return a value"
[Checked in: Comment 4]
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
status-firefox-esr10:
--- → wontfix
status-firefox11:
--- → wontfix
status-firefox12:
--- → wontfix
status-firefox13:
--- → wontfix
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
|
|
Assignee | |
Comment 5•13 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=10599229&tree=Firefox&full=1
Rev3 Fedora 12x64 mozilla-central debug test mochitests-5/5 on 2012-04-03 07:16:33 PDT for push 5128e92c536c
V.Fixed.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•