741145 - python client.py checkout failing when there are no changes

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Jonathan Kamens]

With Fedora 17, mercurial-2.1:

Executing command: ['hg', 'pull', '-R', './.']
pulling from http://hg.mozilla.org/comm-central/
searching for changes
no changes found
The exception was:
subprocess.CalledProcessError: Command '['hg', 'pull', '-R', './.']' returned non-zero exit status 1

Retrying previous command: 1 of 1 time(s)
Executing command: ['hg', 'pull', '-R', './.']
pulling from http://hg.mozilla.org/comm-central/
searching for changes
no changes found
The exception was:
subprocess.CalledProcessError: Command '['hg', 'pull', '-R', './.']' returned non-zero exit status 1

Traceback (most recent call last):
  File "client.py", line 609, in <module>
    do_hg_pull('.', options.comm_repo, options.hg, options.comm_rev)
  File "client.py", line 330, in do_hg_pull
    check_call_noisy(cmd, retryMax=options.retries)
  File "client.py", line 158, in check_call_noisy
    raise Exception("Command '%s' failed %d time(s). Giving up." % (cmd, retryMax + 1))
Exception: Command '['hg', 'pull', '-R', './.']' failed 2 time(s). Giving up.

"hg pull -R ./." is exiting with status 1 when there are no changes to pull, which appears to be by design. client.py needs to be able to cope with this.

Comment 1

[Justin Wood (:Callek)]

I'm sorry, we will not be fixing this, It is a regression in how mercurial was developed. The reverted this change in 2.1.1

http://mercurial.selenic.com/wiki/UpgradeNotes#A2.1.1:_revert_pull_return_code_change.2C_compile_issue_on_OS_X