741591 - [Marketplace] Add "Super Review" flag to apps review queue

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[Christopher Van Wiemeersch [:cvan]]

When an app cannot be rejected or accepted, it should be allowed to be marked for super review. (That is, it will get moved to a new queue, the "Super Review Queue," which only super reviewers will have access to.)

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This is just a matter of exposing a boolean to "Flag for super review". eviljeff recommended just adding this flag to a <td> in the <tr> for each app in the main queue's <table>.

Comment 2

[Rob Hudson [:robhudson]]

Think about putting behind a permission. We previously had "Admin:flagged". Should this be a perm for each queue, e.g. "Addons:Flag", "Apps:Flag", etc?

Comment 3

[Wil Clouser [:clouserw]]

They should be separate, but let's name them something more descriptive than Flag.  SuperReviewFlag?

Comment 4

[Christopher Van Wiemeersch [:cvan]]

eviljeff discussed in #amo that he wanted it to remain as a flag. IMO, we should add a "Super Review" queue - for both AMO and Marketplace (if that makes sense to add-on reviewers). In an ideal world it's easier for admins to track and for non-admins to ignore if the flagged ones are in a separate list.

Comment 5

[Wil Clouser [:clouserw]]

We have (had?) persistent filters on the queue.  It shouldn't be harder or easier to only show flagged add-ons.

Comment 6

[Andrew Williamson [:eviljeff]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #4)
> eviljeff discussed in #amo that he wanted it to remain as a flag. IMO, we
> should add a "Super Review" queue - for both AMO and Marketplace (if that
> makes sense to add-on reviewers). In an ideal world it's easier for admins
> to track and for non-admins to ignore if the flagged ones are in a separate
> list.

I don't have any preference if its a flag or a queue (I can see advantages in both) as long its consistent across apps, addons and themes.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

I'd rather have it be just a flag and not a separate queue. There are hundreds of flagged add-ons that shouldn't be flagged anymore, and the current setup allows some senior (not admin) reviewers to take care of them without having to worry about the flags. Moving them to a different queue would also make it more difficult to have accurate stats about queue movement.

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/4d264d5