Implement dppx unit for resolution media query

RESOLVED FIXED in mozilla16

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: fantasai, Assigned: dbaron)

Tracking

(Blocks: 1 bug, {dev-doc-complete})

unspecified
mozilla16
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
CSS3 Values and Units defines a 'dppx' unit for <resolution>.
  http://www.w3.org/TR/css3-values/#resolution

This bug is for implementing it.

Note: This would implement the same functionality as the non-standard 'device-pixel-ratio' query added in bug 474356.
Keywords: dev-doc-needed

Comment 1

5 years ago
Note that there's currently a discussion about renaming 'dppx' to just 'x':

http://lists.w3.org/Archives/Public/www-style/2012May/0915.html

Sebastian
(Assignee)

Comment 2

5 years ago
Created attachment 639544 [details] [diff] [review]
patch

goes on top of bug 771390
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #639544 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

5 years ago
Basically passed try (though a few Windows tests still pending):
try: --build d --platform linux,macosx64,win32,android --unittests all --talos none --no-emails
https://tbpl.mozilla.org/?tree=Try&rev=afa60b026c46
Comment on attachment 639544 [details] [diff] [review]
patch

r=me
Attachment #639544 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9a5832fc798
Priority: -- → P3
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/a9a5832fc798
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I've updated: https://developer-new.mozilla.org/en-US/docs/CSS/Resolution who describes the <resolution> data type

and

https://developer-new.mozilla.org/en-US/docs/Firefox_16_for_developers.

(For the moment, until Kuma goes live in a few days, it isn't visible on the main wiki, only via the link given — later remove -new from the URL)
Keywords: dev-doc-needed → dev-doc-complete
(Reporter)

Comment 8

5 years ago
Can you also update our page on 'device-pixel-ratio' to show 'resolution: Ndppx' as the standardized alternative?
I've indicate the info on -moz-device-pixel-ratio in https://developer-new.mozilla.org/en-US/docs/CSS/Media_queries (with a link to your CSSWG article)

Thanks for the hint. It was clearly needed.
I've update the |resolution| section too.
You need to log in before you can comment on or make changes to this bug.