Closed Bug 741710 Opened 12 years ago Closed 12 years ago

Default throttle value on ESR should be 100%

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: scoobidiver, Assigned: rhelmer)

Details

There are only about 200K ADU on ESR and the top-1 crasher has only 59 crashes.
The default throttle value should be 100% like in Fennec.
I think this is WFM. AFAIK, we have taken special care when we added ESR support that those are not throttled, and in fact only crashes matching "Firefox" and the "release" channel are throttled at all, except if they contain comments, when they are unthrottled as well.
Also, throttling is done in the processor, which AFAIK is Backend.
Component: Webapp → Backend
QA Contact: webapp → backend
Rob, Lars, can we verify that Firefox ESR isn't throttled?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #3)
> Rob, Lars, can we verify that Firefox ESR isn't throttled?

Throttling is done by the collector (it flags incoming crashes), configured here:
https://github.com/mozilla/socorro/blob/master/scripts/config/collectorconfig.py.dist#L133

ESR releases have ReleaseChannel set to "esr" right? I think we need to add that to the set of ("nightly", "aurora, "beta") at https://github.com/mozilla/socorro/blob/master/scripts/config/collectorconfig.py.dist#L136 otherwise it'll be caught by the general "Firefox" rule and be throttled to 10%
This was discussed in bug 729658, and behavior is as follows:
Things that are 'Firefox' and not aurora, beta, nightly will be throttled at 10%
Things that are Thunderbird or Fennec will go through at 100%

So the desired behavior change is for Firefox esr releases to be processed at 100%?  Once we have confirmation, we can make that change.
Yes, 'esr' channel should be at 100% - I had the logic wrong in my head, obviously, I thought only the 'release*' channel (and now that I think of it, 'default' possibly as well, though I'm still wondering if that's ideal) would be throttled.

Let's add 'esr' to the set of channels not being throttled.

Oh, and can we make those channel names match the beginning of the ReleaseChannel variable? We really don't want nightly-foo to be throttled, we have that nightly-* pattern for development branches.
The rule that currently catches 'nightly' handles only exact matches. A throttle rule that would catch all of 'nightly-*' could look like this:

    ('ReleaseChannel', lambda x: x.startswith('nightly'), 100)
Can we please get the 'esr' channel throttling fixed to be at 100% ASAP?
Assignee: nobody → rhelmer
Target Milestone: --- → 7
original line:

    ("ReleaseChannel", lambda x: x in ("nightly", "aurora", "beta"), 100),

new version of that line:    

    ("ReleaseChannel", lambda x: x in ("nightly", "aurora", "beta", "esr"), 100),
(In reply to K Lars Lohn [:lars] [:klohn] from comment #9)
> original line:
> 
>     ("ReleaseChannel", lambda x: x in ("nightly", "aurora", "beta"), 100),
> 
> new version of that line:    
> 
>     ("ReleaseChannel", lambda x: x in ("nightly", "aurora", "beta", "esr"),
> 100),

Master:
https://github.com/mozilla/socorro/pull/525

Stage:
https://github.com/mozilla/socorro/pull/527
Status: NEW → ASSIGNED
Cool, thanks! Let's file a separate followup bug for doing what comment #7 suggests, please, we'd like to have that as well in the future.
Commits pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c2e6d6037ae2f566816cc48ef1bf0a34f5124d4d
bug 741710 - default ESR throttle level should be 100%

https://github.com/mozilla/socorro/commit/34fd7a9b2ba026c8c6297576097c27ad07b4d015
Merge pull request #527 from rhelmer/stage

bug 741710 - default ESR throttle level should be 100%
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/809a26bf09717103c310de179a21195f99dc6e4d
bug 741710 - default ESR throttle level should be 100%

https://github.com/mozilla/socorro/commit/a103c2d7141457d5eb85bf1e0b7f24f096c64543
Merge pull request #525 from rhelmer/bug741710-default-esr-throttle-level

bug 741710 - default ESR throttle level should be 100%
I spun off bug 748774 for the nightly change.

This one is fixed and will ship today.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
QA verified on prod default throttle values for ESR releases are 100%
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.