742236 - Get rid of the harcoded retrievalLimit in gloda and make that limit configurable

Status: RESOLVED FIXED

(Thunderbird :: Search, enhancement)

Description

[Ludovic Hirlimann [:Usul]]

Could we set the limit in a pref so people willing to change it could ?

Comment 1

[Wayne Mery (:wsmwk)]

xref Bug 537856 - [faceted search] UI should convey that results are limited to 400 messages

Comment 2

[:aceman]

Yes, a pref please :)

Comment 3

[Jim Porter (:squib)]

Taking this. It'd probably be good for debugging purposes too.

MXR results for future reference: http://mxr.mozilla.org/comm-central/search?string=retrievalLimit&filter=[Rr]etrievalLimit

Comment 4

[Jim Porter (:squib)]

Attachment: Add prefs for setting retrievalLimit

Ok, I added prefs for this (one for mail and one for IM). I also set the new limit to 1000, since that seems to perform well on my system, and it's been a few years since we (arbitrarily) set the limit to 400. We could probably go even higher, but I'm erring on the side of caution.

Here is a try build: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=b76844b2f80c

Comment 5

[Magnus Melin [:mkmelin]]

Comment on attachment 8369209 [details] [diff] [review]
Add prefs for setting retrievalLimit

Review of attachment 8369209 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=mkmelin

Comment 6

[Jim Porter (:squib)]

Landed: https://hg.mozilla.org/comm-central/rev/4128251fd05f