742267 - URL content is cleared when entering a new character from the hardware keyboard

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Adrian Tamas (:AdrianT)]

Fennec/14.0a1 2012-04-04
Device: Motorola Droid Pro (Android 2.3)/ Motorola Droid 2(Android 2.3)

Steps to reproduce:
*Open the hardware keyboard 
1. Open Nightly.
2. Visit any link.
3. Tap in the url bar and move the cursor at the end of the text.
4. Delete a few characters and then type new ones. ( for example go to mozilla.com and then change it to mozilla.org by typing "org" instead of "com")

Expected results:
The user can edit part of the URL.

Actual results:
When entering a new character the URL is cleared.

Please see the video:
http://youtu.be/2S9-bNKE6xw

Comment 1

[Chris Peterson [:cpeterson]]

blocking-fennec1.0=? because URL cannot be modified, only overwritten, with HKB.

Simpler STR:
1. Visit any link
2. Tap URL bar
3. Try to edit the URL by inserting or appending any characters

You don't need to move cursor to the end of the URL text or delete any characters.

Comment 2

[Chris Peterson [:cpeterson]]

This probably only affects HKB. If I use Simeji IME on the Droid Pro, URL editing works correctly.

Comment 3

[Chris Peterson [:cpeterson]]

qawanted, does this affect devices (with HKB) other than Droid Pro?

Comment 4

[Chris Peterson [:cpeterson]]

I was able to repro on Droid 2 HKB.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

https://bugzilla.mozilla.org/show_bug.cgi?id=713060#c9

Comment 6

[Chris Peterson [:cpeterson]]

Attachment: bug-742267-restore-cursor-position.patch

Restore AwesomeBar's cursor position when gaining input focus.

Comment 7

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/mozilla-central/rev/d3a3b430e951

Comment 8

[Chris Peterson [:cpeterson]]

Comment on attachment 620045 [details] [diff] [review]
bug-742267-restore-cursor-position.patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: Android user can't modify AwesomeBar's (search or URL) text using hardware keyboard (only overwrite previous text). VKB works correctly.
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Android-only. Maybe cursor problems when editing AwesomeBar text.
String changes made by this patch: N/A

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

can we fast track the verification?

Comment 10

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 15.0a1 (2012-05-02)20120502030505
Motorola Droid Pro 2.3

Still needs to be verified on Aurora when the fix lands.

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 620045 [details] [diff] [review]
bug-742267-restore-cursor-position.patch

[Triage Comment]
Fennec 1.0 blocker, approved for Aurora 14.

Comment 12

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2d7dd84abf1a

Comment 13

[Catalin Suciu [:csuciu]]

Verified fixed on:
Aurora 14.0a2 (2012-05-28) 
Beta 14.ob3 build 2

Device: Motorola Droid Pro (Android 2.3)