The default bug view has changed. See this FAQ.

add tooltips to the "add/remove action" button in filter editor

RESOLVED FIXED in Thunderbird 15.0

Status

MailNews Core
Filters
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

({polish, ux-consistency})

Trunk
Thunderbird 15.0
polish, ux-consistency
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [real description is comment 1])

Attachments

(1 attachment, 2 obsolete attachments)

3.22 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #736860 +++

Unify the character used for minus signs on buttons to remove filter rules and filter actions in the Filter editor.
I suggest to use \u2212 character as that one is rendered longer and in line with the plus sign. It is already used on the remove filter rule button.
(Assignee)

Comment 1

5 years ago
Sorry, the description got copied from the previous bug and I forgot to update it.

THE REAL DESCRIPTION IS THIS:
Add tooltips and accesskeys to the "add/remove action" button in filter editor. The plus and minus buttons located in the actions list do not have any. The buttons in the rules list have tooltips for what they mean.

Any good proposals for the accesskeys?
Summary: add tooltips and accesskey to the "add/remove action button" in filter editor → add tooltips and accesskeys to the "add/remove action" button in filter editor
Whiteboard: [real description is comment 1]
(Assignee)

Comment 2

5 years ago
Created attachment 615027 [details] [diff] [review]
patch

I am not sure it is wanted to add accesskeys here. See the patch in action. The + sign is underlined on the buttons and minus is in bracket, which is ugly. As the buttons occur several times in the window, the accesskeys work but cycle the focus over all the same buttons.

The tooltips should be OK.
Attachment #615027 - Flags: ui-review?(bwinton)
Attachment #615027 - Flags: feedback?(iann_bugzilla)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 615027 [details] [diff] [review]
patch

I agree that we shouldn't have the accesskeys, since they look _really_ odd, but I'm looping in Accessibility Guru MarcoZ to get some feedback on how we should handle access keys for "+" and "-".  (Perhaps we should add "(+)" and "(-)" to the end of the tooltiptext?)

ui-r=me with that change.

Thanks,
Blake.
Attachment #615027 - Flags: ui-review?(bwinton)
Attachment #615027 - Flags: ui-review+
Attachment #615027 - Flags: feedback?(marco.zehe)

Comment 4

5 years ago
Comment on attachment 615027 [details] [diff] [review]
patch

Yes, this is good, it will add the tooltip as a description and give the users more context. And yes, having + and - as access keys is odd.
Attachment #615027 - Flags: feedback?(marco.zehe) → feedback+
(Assignee)

Comment 5

5 years ago
Thanks, so what is the resolution?
No accesskeys? And the tooltips as they are now?
(Assignee)

Updated

5 years ago
Attachment #615027 - Flags: feedback?(iann_bugzilla)
aceman: "ui-r=me with that change."  ;)

So, definitely no accesskeys, and add "(+)" and "(-)" if you think it looks better.  (I trust you to make that decision. :)

Later,
Blake.
(Assignee)

Comment 7

5 years ago
Why should I add "(+)" and "(-)" to the tooltip when + and - will not be the accesskeys? I do not understand this part.
D'oh!  Yes, it would be better not to add them, then.
(Assignee)

Comment 9

5 years ago
Created attachment 617072 [details] [diff] [review]
patch v2
Attachment #615027 - Attachment is obsolete: true
Attachment #617072 - Flags: review?(mconley)
(Assignee)

Updated

5 years ago
Attachment #617072 - Flags: review?(iann_bugzilla)

Comment 10

5 years ago
Comment on attachment 617072 [details] [diff] [review]
patch v2

>+<!ENTITY addAction.label "Add a new action">
>+<!ENTITY removeAction.label "Remove this action">
Nit: tooltiptext entities tend to be foo.tooltip rather than foo.label

r=me with that fixed
Attachment #617072 - Flags: review?(iann_bugzilla) → review+
Summary: add tooltips and accesskeys to the "add/remove action" button in filter editor → add tooltips to the "add/remove action" button in filter editor
Comment on attachment 617072 [details] [diff] [review]
patch v2

Ian's right about the tooltip change to the string keys.

Other than that, this looks pretty solid.

Thanks aceman - keep up the good work!
Attachment #617072 - Flags: review?(mconley) → review+
(Assignee)

Comment 12

5 years ago
Created attachment 618031 [details] [diff] [review]
patch v3

Thanks, fixed.
Attachment #617072 - Attachment is obsolete: true
Attachment #618031 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/80d1345ca679
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in before you can comment on or make changes to this bug.