742472 - add tooltips to the "add/remove action" button in filter editor

Status: RESOLVED FIXED

(MailNews Core :: Filters, defect)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #736860 +++

Unify the character used for minus signs on buttons to remove filter rules and filter actions in the Filter editor.
I suggest to use \u2212 character as that one is rendered longer and in line with the plus sign. It is already used on the remove filter rule button.

Comment 1

[:aceman]

Sorry, the description got copied from the previous bug and I forgot to update it.

THE REAL DESCRIPTION IS THIS:
Add tooltips and accesskeys to the "add/remove action" button in filter editor. The plus and minus buttons located in the actions list do not have any. The buttons in the rules list have tooltips for what they mean.

Any good proposals for the accesskeys?

Comment 2

[:aceman]

Attachment: patch

I am not sure it is wanted to add accesskeys here. See the patch in action. The + sign is underlined on the buttons and minus is in bracket, which is ugly. As the buttons occur several times in the window, the accesskeys work but cycle the focus over all the same buttons.

The tooltips should be OK.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 615027 [details] [diff] [review]
patch

I agree that we shouldn't have the accesskeys, since they look _really_ odd, but I'm looping in Accessibility Guru MarcoZ to get some feedback on how we should handle access keys for "+" and "-".  (Perhaps we should add "(+)" and "(-)" to the end of the tooltiptext?)

ui-r=me with that change.

Thanks,
Blake.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 615027 [details] [diff] [review]
patch

Yes, this is good, it will add the tooltip as a description and give the users more context. And yes, having + and - as access keys is odd.

Comment 5

[:aceman]

Thanks, so what is the resolution?
No accesskeys? And the tooltips as they are now?

Comment 6

[Blake Winton (:bwinton) (:☕️)]

aceman: "ui-r=me with that change."  ;)

So, definitely no accesskeys, and add "(+)" and "(-)" if you think it looks better.  (I trust you to make that decision. :)

Later,
Blake.

Comment 7

[:aceman]

Why should I add "(+)" and "(-)" to the tooltip when + and - will not be the accesskeys? I do not understand this part.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

D'oh!  Yes, it would be better not to add them, then.

Comment 9

[:aceman]

Attachment: patch v2

Comment 10

[Ian Neal]

Comment on attachment 617072 [details] [diff] [review]
patch v2

>+<!ENTITY addAction.label "Add a new action">
>+<!ENTITY removeAction.label "Remove this action">
Nit: tooltiptext entities tend to be foo.tooltip rather than foo.label

r=me with that fixed

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 617072 [details] [diff] [review]
patch v2

Ian's right about the tooltip change to the string keys.

Other than that, this looks pretty solid.

Thanks aceman - keep up the good work!

Comment 12

[:aceman]

Attachment: patch v3

Thanks, fixed.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/comm-central/rev/80d1345ca679