742478 - Integrate appropriate icons for sending & receiving tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Marina Samuel [:emtwo]]

For whatever icons replace the Firefox Sync icon in the following images, 3 size will be required. 72x72, 48x48, 36x36 pixels

The images used for monitor & mobile in the sendtab.png are 32x32 pixels.

Comment 1

[Marina Samuel [:emtwo]]

Attachment: Screen for sending tabs.

Comment 2

[Marina Samuel [:emtwo]]

Attachment: Receive a tab notification at the bottom.

Comment 3

[Gregory Szorc [:gps]]

\o/

Comment 4

[Marina Samuel [:emtwo]]

Attachment: Share button shows Firefox Sync as an option to send the tab.

Comment 5

[Marina Samuel [:emtwo]]

Attachment: Screen for sending tabs.

This screenshot just has the checkboxes unchecked as they are when the screen first opens.

Comment 6

[Allison Naaktgeboren :ally]

requesting UX input on type and importance. Ian, I dont think we need to worry about this for release or beta, but it feels like a good polish bug. Thoughts?

Comment 7

[Ian Barlow (:ibarlow)]

Soft blocker nom?

I agree it would add a nice bit of polish to the app if someone has time to push it along. I can provide some graphics for this right away if it's marked as a blocker.

Comment 8

[Allison Naaktgeboren :ally]

de-noming. this feature wont land until after the first release.

Comment 9

[Ian Barlow (:ibarlow)]

Here are some assets for the send tab menu: http://cl.ly/3H3w3V1c0L413L0f0W1g 

Included are Firefox icons at the relevant sizes, and icons for different device types. Here is a mockup of everything put together http://cl.ly/431Q2v0A2V1x2K1M3t34

You'll notice that I have different icons for Phone, Tablet, Laptop and Desktop, and not just desktop vs mobile. It would be great if there were a way to get this level of detail in our sync info, it would help make this menu even more useful!

Comment 10

[Richard Newman [:rnewman]]

To go with Bug 739416 and Bug 740193.

Comment 11

[Richard Newman [:rnewman]]

Until we address granularity of the client type in Bug 745412, I'm going to use desktop and phone as the two icons for desktop and mobile.

For the former, although laptops are now more prevalent than desktops, external displays are still widely used, and this avoids confusion with keyboarded tablets. For the latter, Fennec still primarily targets phones, and Android has a consumer association with a spectrum of small portrait devices, so it kinda works for tablets for now.

Comment 12

[Richard Newman [:rnewman]]

Oh, and Ian: could you please produce a 96x96 Firefox icon for xdpi screens?

Comment 13

[Richard Newman [:rnewman]]

Attachment: Patch. v1

Dumping this here while I wait for the build to finish.

Comment 14

[Richard Newman [:rnewman]]

Integrated the Firefox, phone, and desktop icons. Tested.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4297a8802cd5

Comment 15

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/4297a8802cd5

Comment 16

[Richard Newman [:rnewman]]

Accidentally landed some resource files that shouldn't be there.

https://hg.mozilla.org/integration/mozilla-inbound/rev/78dce09ed250

Comment 17

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/78dce09ed250

Comment 18

[Andreea Pod]

Verified fixed on:

Build: Firefox 16.0 Beta 2 build 2
Device: Samsung Galaxy Nexus
OS: Android 4.1.1